public/main/inc/lib/formvalidator/Rule/DateCompare.php
Avoid unused parameters such as '$operator'. Open
Open
public function validate($values, $operator = null)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
The class HTML_QuickForm_Rule_DateCompare is not named in CamelCase. Open
Open
class HTML_QuickForm_Rule_DateCompare extends HTML_QuickForm_Rule_Compare
{
/**
* Validate 2 dates.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Missing parameter name Open
Open
* @param $operator- Exclude checks
Expected 4 spaces after parameter type; 1 found Open
Open
* @param array $values array with the 2 dates- Exclude checks
Class name "HTML_QuickForm_Rule_DateCompare" is not in camel caps format Open
Open
class HTML_QuickForm_Rule_DateCompare extends HTML_QuickForm_Rule_Compare- Exclude checks