public/main/inc/lib/formvalidator/Rule/UploadFile.php
Avoid unused parameters such as '$regex'. Open
Open
public function validate($elementValue, $regex)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
The method validate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
return false;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The class HTML_QuickForm_Rule_UploadFile is not named in CamelCase. Open
Open
class HTML_QuickForm_Rule_UploadFile extends HTML_QuickForm_Rule
{
/**
* Checks if the given element contains an uploaded file of the filename regex.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Doc comment for parameter $_FILES) does not match actual variable name $elementValue Open
Open
* @param array Uploaded file info (from $_FILES)- Exclude checks
Missing parameter name Open
Open
* @param string Regular expression- Exclude checks
Class name "HTML_QuickForm_Rule_UploadFile" is not in camel caps format Open
Open
class HTML_QuickForm_Rule_UploadFile extends HTML_QuickForm_Rule- Exclude checks