public/main/inc/lib/formvalidator/Rule/Username.php
Avoid unused parameters such as '$options'. Open
Open
public function validate($username, $options)- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
The method validate uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
return UserManager::is_username_valid($username);
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The class HTML_QuickForm_Rule_Username is not named in CamelCase. Open
Open
class HTML_QuickForm_Rule_Username extends HTML_QuickForm_Rule
{
/**
* Function to check if a username is of the correct format.
*- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Class name "HTML_QuickForm_Rule_Username" is not in camel caps format Open
Open
class HTML_QuickForm_Rule_Username extends HTML_QuickForm_Rule- Exclude checks