public/main/inc/lib/search/ChamiloIndexer.class.php
Avoid unused parameters such as '$ref_id_second_level'. Open
Open
$ref_id_second_level,- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
The parameter $tool_id is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $course_code is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $tool_id is not named in camelCase. Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)
{
require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
$terms = get_specific_field_values_list_by_prefix(
$prefix,- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $ref_id_second_level is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $terms_string is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $ref_id_high_level is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $course_code is not named in camelCase. Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)
{
require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
$terms = get_specific_field_values_list_by_prefix(
$prefix,- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $search_did is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
The parameter $ref_id is not named in camelCase. Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)
{
require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
$terms = get_specific_field_values_list_by_prefix(
$prefix,- Read upRead up
- Exclude checks
CamelCaseParameterName
Since: 0.2
It is considered best practice to use the camelCase notation to name parameters.
Example
class ClassName {
public function doSomething($user_name) {
}
}Source
Variable "course_code" is not in valid camel caps format Open
Open
$course_code,- Exclude checks
Variable "tool_id" is not in valid camel caps format Open
Open
$tool_id,- Exclude checks
Variable "ref_id_second_level" is not in valid camel caps format Open
Open
$ref_id_second_level,- Exclude checks
Variable "stored_terms" is not in valid camel caps format Open
Open
if ((0 == count(array_diff($terms, $stored_terms))) &&- Exclude checks
Variable "search_did" is not in valid camel caps format Open
Open
$this->replace_document($doc, (int) $search_did);- Exclude checks
Variable "terms_string" is not in valid camel caps format Open
Open
$terms_string = trim($terms_string);- Exclude checks
Variable "terms_string" is not in valid camel caps format Open
Open
$terms = explode(',', $terms_string);- Exclude checks
Variable "terms_string" is not in valid camel caps format Open
Open
$terms_string,- Exclude checks
Variable "stored_terms" is not in valid camel caps format Open
Open
$stored_terms = $this->get_terms_on_db($prefix, $course_code, $tool_id, $ref_id_high_level);- Exclude checks
Variable "xapian_term" is not in valid camel caps format Open
Open
foreach ($xapian_terms as $xapian_term) {- Exclude checks
Variable "terms_string" is not in valid camel caps format Open
Open
$terms_string = trim($terms_string);- Exclude checks
Variable "search_did" is not in valid camel caps format Open
Open
$doc = $this->get_document($search_did);- Exclude checks
Method name "ChamiloIndexer::get_terms_on_db" is not in camel caps format Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)- Exclude checks
Variable "xapian_terms" is not in valid camel caps format Open
Open
$xapian_terms = xapian_get_doc_terms($doc, $prefix);- Exclude checks
Variable "ref_id" is not in valid camel caps format Open
Open
$ref_id- Exclude checks
Variable "deprecated_terms" is not in valid camel caps format Open
Open
foreach ($deprecated_terms as $term) {- Exclude checks
Variable "prefix_terms" is not in valid camel caps format Open
Open
$prefix_terms[] = $term['value'];- Exclude checks
Variable "xapian_terms" is not in valid camel caps format Open
Open
foreach ($xapian_terms as $xapian_term) {- Exclude checks
Variable "missing_terms" is not in valid camel caps format Open
Open
$missing_terms = array_diff($dterms, $xterms);- Exclude checks
Variable "ref_id_high_level" is not in valid camel caps format Open
Open
$stored_terms = $this->get_terms_on_db($prefix, $course_code, $tool_id, $ref_id_high_level);- Exclude checks
Variable "deprecated_terms" is not in valid camel caps format Open
Open
if ((count($missing_terms) > 0) || (count($deprecated_terms) > 0)) {- Exclude checks
Variable "deprecated_terms" is not in valid camel caps format Open
Open
$deprecated_terms = array_diff($xterms, $dterms);- Exclude checks
Variable "course_code" is not in valid camel caps format Open
Open
$course_code,- Exclude checks
Variable "prefix_terms" is not in valid camel caps format Open
Open
return $prefix_terms;- Exclude checks
Variable "course_code" is not in valid camel caps format Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)- Exclude checks
Variable "prefix_terms" is not in valid camel caps format Open
Open
$prefix_terms = [];- Exclude checks
Variable "ref_id_high_level" is not in valid camel caps format Open
Open
$ref_id_high_level,- Exclude checks
Variable "ref_id" is not in valid camel caps format Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)- Exclude checks
Variable "search_did" is not in valid camel caps format Open
Open
$search_did- Exclude checks
Variable "course_code" is not in valid camel caps format Open
Open
$stored_terms = $this->get_terms_on_db($prefix, $course_code, $tool_id, $ref_id_high_level);- Exclude checks
Variable "stored_terms" is not in valid camel caps format Open
Open
(0 == count(array_diff($stored_terms, $terms)))- Exclude checks
Variable "tool_id" is not in valid camel caps format Open
Open
$stored_terms = $this->get_terms_on_db($prefix, $course_code, $tool_id, $ref_id_high_level);- Exclude checks
Variable "xapian_term" is not in valid camel caps format Open
Open
$xterms[] = substr($xapian_term['name'], 1);- Exclude checks
Variable "missing_terms" is not in valid camel caps format Open
Open
foreach ($missing_terms as $term) {- Exclude checks
Method name "ChamiloIndexer::set_terms" is not in camel caps format Open
Open
public function set_terms(- Exclude checks
Variable "missing_terms" is not in valid camel caps format Open
Open
if ((count($missing_terms) > 0) || (count($deprecated_terms) > 0)) {- Exclude checks
Variable "tool_id" is not in valid camel caps format Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)- Exclude checks
Variable "tool_id" is not in valid camel caps format Open
Open
$tool_id,- Exclude checks
The variable $terms_string is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $xapian_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $prefix_terms is not named in camelCase. Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)
{
require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
$terms = get_specific_field_values_list_by_prefix(
$prefix,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $tool_id is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $stored_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $deprecated_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $course_code is not named in camelCase. Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)
{
require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
$terms = get_specific_field_values_list_by_prefix(
$prefix,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $search_did is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $terms_string is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $stored_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $stored_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $xapian_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $missing_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $ref_id_high_level is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $prefix_terms is not named in camelCase. Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)
{
require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
$terms = get_specific_field_values_list_by_prefix(
$prefix,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $missing_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $tool_id is not named in camelCase. Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)
{
require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
$terms = get_specific_field_values_list_by_prefix(
$prefix,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $ref_id is not named in camelCase. Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)
{
require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
$terms = get_specific_field_values_list_by_prefix(
$prefix,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $terms_string is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $deprecated_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $xapian_term is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $prefix_terms is not named in camelCase. Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)
{
require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
$terms = get_specific_field_values_list_by_prefix(
$prefix,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $course_code is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $deprecated_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $xapian_term is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $search_did is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $missing_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The method get_terms_on_db is not named in camelCase. Open
Open
public function get_terms_on_db($prefix, $course_code, $tool_id, $ref_id)
{
require_once api_get_path(LIBRARY_PATH).'specific_fields_manager.lib.php';
$terms = get_specific_field_values_list_by_prefix(
$prefix,- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method set_terms is not named in camelCase. Open
Open
public function set_terms(
$terms_string,
$prefix,
$course_code,
$tool_id,- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}