public/main/inc/lib/skill.visualizer.lib.php
Avoid unused local variables such as '$id'. Open
Open
foreach ($this->skills[$skill['parent_id']]['children'] as $id => $sk) {- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$brothers'. Open
Open
$brothers = [];- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$count'. Open
Open
$count = 0;- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$skill_count'. Open
Open
$skill_count = sizeof($this->skills);- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$childs'. Open
Open
$childs = isset($skill['children']) ? count($skill['children']) : 0;- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
Avoid unused local variables such as '$max'. Open
Open
$max = isset($this->skills[$skill['parent_id']]['children']) ? count($this->skills[$skill['parent_id']]['children']) : 0;- Read upRead up
- Exclude checks
UnusedLocalVariable
Since: 0.2
Detects when a local variable is declared and/or assigned, but not used.
Example
class Foo {
public function doSomething()
{
$i = 5; // Unused
}
}Source https://phpmd.org/rules/unusedcode.html#unusedlocalvariable
The method add_item uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
if (1 == $skill['done_by_user']) {
$class = 'done_window';
$end_point = 'doneEndpoint';
} else {- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method return_html uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$max = isset($this->skills[$skill['parent_id']]['children']) ? count($this->skills[$skill['parent_id']]['children']) : 0;
foreach ($this->skills[$skill['parent_id']]['children'] as $id => $sk) {
if ($skill['id'] == $sk['id']) {
break;- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method add_item uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$end_point = 'defaultEndpoint';
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The property $space_between_blocks_y is not named in camelCase. Open
Open
class SkillVisualizer
{
public $block_size = 120; //see CSS window class
public $canvas_x = 1024;
public $canvas_y = 800;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $center_x is not named in camelCase. Open
Open
class SkillVisualizer
{
public $block_size = 120; //see CSS window class
public $canvas_x = 1024;
public $canvas_y = 800;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $canvas_x is not named in camelCase. Open
Open
class SkillVisualizer
{
public $block_size = 120; //see CSS window class
public $canvas_x = 1024;
public $canvas_y = 800;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $offset_x is not named in camelCase. Open
Open
class SkillVisualizer
{
public $block_size = 120; //see CSS window class
public $canvas_x = 1024;
public $canvas_y = 800;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $block_size is not named in camelCase. Open
Open
class SkillVisualizer
{
public $block_size = 120; //see CSS window class
public $canvas_x = 1024;
public $canvas_y = 800;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $canvas_y is not named in camelCase. Open
Open
class SkillVisualizer
{
public $block_size = 120; //see CSS window class
public $canvas_x = 1024;
public $canvas_y = 800;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $offset_y is not named in camelCase. Open
Open
class SkillVisualizer
{
public $block_size = 120; //see CSS window class
public $canvas_x = 1024;
public $canvas_y = 800;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
The property $space_between_blocks_x is not named in camelCase. Open
Open
class SkillVisualizer
{
public $block_size = 120; //see CSS window class
public $canvas_x = 1024;
public $canvas_y = 800;- Read upRead up
- Exclude checks
CamelCasePropertyName
Since: 0.2
It is considered best practice to use the camelCase notation to name attributes.
Example
class ClassName {
protected $property_name;
}Source
Member variable "space_between_blocks_y" is not in valid camel caps format Open
Open
public $space_between_blocks_y = 150;- Exclude checks
Missing parameter name Open
Open
* @param $position- Exclude checks
Variable "end_point" is not in valid camel caps format Open
Open
$end_point = 'editEndpoint';- Exclude checks
Member variable "canvas_x" is not in valid camel caps format Open
Open
public $canvas_x = 1024;- Exclude checks
Variable "center_x" is not in valid camel caps format Open
Open
$this->center_x = intval($this->offset_x + $this->canvas_x / 2 - $this->block_size / 2);- Exclude checks
Variable "my_count" is not in valid camel caps format Open
Open
$my_count++;- Exclude checks
Variable "end_point" is not in valid camel caps format Open
Open
$end_point = 'readEndpoint';- Exclude checks
Member variable "block_size" is not in valid camel caps format Open
Open
public $block_size = 120; //see CSS window class- Exclude checks
Variable "block_id" is not in valid camel caps format Open
Open
$this->html .= '<div id="block_'.$block_id.'" class = "open_block window '.$extra_class.' '.$class.'" style = "top:'.$position['y'].'px; left:'.$position['x'].'px;">';- Exclude checks
Method name "SkillVisualizer::display_html" is not in camel caps format Open
Open
public function display_html()- Exclude checks
Variable "skill_count" is not in valid camel caps format Open
Open
$skill_count = sizeof($this->skills);- Exclude checks
Variable "offset_x" is not in valid camel caps format Open
Open
$this->add_item($skill, ['x' => $this->offset_x + $x, 'y' => $this->offset_y + $y]);- Exclude checks
Variable "block_id" is not in valid camel caps format Open
Open
$this->js .= 'var e'.$block_id.' = prepare("block_'.$block_id.'", '.$end_point.');'."\n";- Exclude checks
Variable "block_id" is not in valid camel caps format Open
Open
$this->js .= 'var e'.$block_id.' = prepare("block_'.$block_id.'", '.$end_point.');'."\n";- Exclude checks
Variable "block_id" is not in valid camel caps format Open
Open
$block_id = $skill['id'];- Exclude checks
Variable "canvas_x" is not in valid camel caps format Open
Open
$x = $this->canvas_x / 2 - $this->block_size / 2;- Exclude checks
Variable "my_count" is not in valid camel caps format Open
Open
$x = $my_count * $this->space_between_blocks_x + $parent_x + $this->block_size - ($this->canvas_x / 2);- Exclude checks
Member variable "center_x" is not in valid camel caps format Open
Open
public $center_x = null;- Exclude checks
Method name "SkillVisualizer::return_html" is not in camel caps format Open
Open
public function return_html()- Exclude checks
Variable "block_id" is not in valid camel caps format Open
Open
$content .= Display::url(get_lang('Edit'), '#', ['id' => 'edit_block_'.$block_id, 'class' => 'edit_block btn']);- Exclude checks
Missing function doc comment Open
Open
public function return_js()- Exclude checks
Variable "block_id" is not in valid camel caps format Open
Open
$block_id = $skill['id'];- Exclude checks
Variable "parent_x" is not in valid camel caps format Open
Open
$parent_x = isset($this->skills[$skill['parent_id']]['x']) ? $this->skills[$skill['parent_id']]['x'] : 0;- Exclude checks
Variable "block_id" is not in valid camel caps format Open
Open
$this->js .= 'jsPlumb.connect({source: e'.$block_id.', target:e'.$skill['parent_id'].'});'."\n";- Exclude checks
Variable "offset_x" is not in valid camel caps format Open
Open
$this->center_x = intval($this->offset_x + $this->canvas_x / 2 - $this->block_size / 2);- Exclude checks
Method name "SkillVisualizer::prepare_skill_box" is not in camel caps format Open
Open
public function prepare_skill_box($skill, $position, $class)- Exclude checks
Variable "my_count" is not in valid camel caps format Open
Open
$my_count = 0;- Exclude checks
Method name "SkillVisualizer::get_js" is not in camel caps format Open
Open
private function get_js()- Exclude checks
Member variable "offset_x" is not in valid camel caps format Open
Open
public $offset_x = 0;- Exclude checks
Variable "block_size" is not in valid camel caps format Open
Open
$this->center_x = intval($this->offset_x + $this->canvas_x / 2 - $this->block_size / 2);- Exclude checks
Missing parameter name Open
Open
* @param $class- Exclude checks
Variable "end_point" is not in valid camel caps format Open
Open
$end_point = 'defaultEndpoint';- Exclude checks
Variable "end_point" is not in valid camel caps format Open
Open
$this->js .= 'var e'.$skill['parent_id'].' = prepare("block_'.$skill['parent_id'].'", '.$end_point.');'."\n";- Exclude checks
Member variable "offset_y" is not in valid camel caps format Open
Open
public $offset_y = 50;- Exclude checks
Method name "SkillVisualizer::display_js" is not in camel caps format Open
Open
public function display_js()- Exclude checks
Variable "end_point" is not in valid camel caps format Open
Open
$end_point = 'doneEndpoint';- Exclude checks
Member variable "canvas_y" is not in valid camel caps format Open
Open
public $canvas_y = 800;- Exclude checks
Missing parameter name Open
Open
* @param $skills- Exclude checks
Variable "extra_class" is not in valid camel caps format Open
Open
$extra_class = 'second_window';- Exclude checks
Variable "space_between_blocks_y" is not in valid camel caps format Open
Open
$y = $skill['level'] * $this->space_between_blocks_y;- Exclude checks
Method name "SkillVisualizer::get_html" is not in camel caps format Open
Open
private function get_html()- Exclude checks
Variable "parent_x" is not in valid camel caps format Open
Open
$parent_x = 0;- Exclude checks
Variable "block_size" is not in valid camel caps format Open
Open
$x = $this->canvas_x / 2 - $this->block_size / 2;- Exclude checks
Variable "end_point" is not in valid camel caps format Open
Open
$this->js .= 'var e'.$block_id.' = prepare("block_'.$block_id.'", '.$end_point.');'."\n";- Exclude checks
Member variable "space_between_blocks_x" is not in valid camel caps format Open
Open
public $space_between_blocks_x = 100;- Exclude checks
Missing parameter name Open
Open
* @param $skill- Exclude checks
Variable "space_between_blocks_x" is not in valid camel caps format Open
Open
$x = $my_count * $this->space_between_blocks_x + $parent_x + $this->block_size - ($this->canvas_x / 2);- Exclude checks
Method name "SkillVisualizer::return_js" is not in camel caps format Open
Open
public function return_js()- Exclude checks
Variable "offset_y" is not in valid camel caps format Open
Open
$this->add_item($skill, ['x' => $this->offset_x + $x, 'y' => $this->offset_y + $y]);- Exclude checks
Variable "extra_class" is not in valid camel caps format Open
Open
$extra_class = 'third_window';- Exclude checks
Variable "extra_class" is not in valid camel caps format Open
Open
$this->html .= '<div id="block_'.$block_id.'" class = "open_block window '.$extra_class.' '.$class.'" style = "top:'.$position['y'].'px; left:'.$position['x'].'px;">';- Exclude checks
Missing function doc comment Open
Open
public function return_html()- Exclude checks
Variable "parent_x" is not in valid camel caps format Open
Open
$x = $my_count * $this->space_between_blocks_x + $parent_x + $this->block_size - ($this->canvas_x / 2);- Exclude checks
Variable "canvas_x" is not in valid camel caps format Open
Open
$this->center_x = intval($this->offset_x + $this->canvas_x / 2 - $this->block_size / 2);- Exclude checks
Variable "block_id" is not in valid camel caps format Open
Open
$content .= Display::url('+', '#', ['id' => 'edit_block_'.$block_id, 'class' => 'edit_block btn']);- Exclude checks
Variable "block_size" is not in valid camel caps format Open
Open
$x = $my_count * $this->space_between_blocks_x + $parent_x + $this->block_size - ($this->canvas_x / 2);- Exclude checks
Variable "canvas_x" is not in valid camel caps format Open
Open
$x = $my_count * $this->space_between_blocks_x + $parent_x + $this->block_size - ($this->canvas_x / 2);- Exclude checks
Method name "SkillVisualizer::add_item" is not in camel caps format Open
Open
private function add_item($skill, $position)- Exclude checks
The variable $my_count is not named in camelCase. Open
Open
public function return_html()
{
if (empty($this->skills)) {
return '';
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $end_point is not named in camelCase. Open
Open
private function add_item($skill, $position)
{
$block_id = $skill['id'];
$end_point = 'readEndpoint';
$class = 'default_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $block_id is not named in camelCase. Open
Open
private function add_item($skill, $position)
{
$block_id = $skill['id'];
$end_point = 'readEndpoint';
$class = 'default_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $extra_class is not named in camelCase. Open
Open
public function prepare_skill_box($skill, $position, $class)
{
$block_id = $skill['id'];
$extra_class = 'third_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $end_point is not named in camelCase. Open
Open
private function add_item($skill, $position)
{
$block_id = $skill['id'];
$end_point = 'readEndpoint';
$class = 'default_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $extra_class is not named in camelCase. Open
Open
public function prepare_skill_box($skill, $position, $class)
{
$block_id = $skill['id'];
$extra_class = 'third_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $end_point is not named in camelCase. Open
Open
private function add_item($skill, $position)
{
$block_id = $skill['id'];
$end_point = 'readEndpoint';
$class = 'default_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $end_point is not named in camelCase. Open
Open
private function add_item($skill, $position)
{
$block_id = $skill['id'];
$end_point = 'readEndpoint';
$class = 'default_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $my_count is not named in camelCase. Open
Open
public function return_html()
{
if (empty($this->skills)) {
return '';
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $parent_x is not named in camelCase. Open
Open
public function return_html()
{
if (empty($this->skills)) {
return '';
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $block_id is not named in camelCase. Open
Open
private function add_item($skill, $position)
{
$block_id = $skill['id'];
$end_point = 'readEndpoint';
$class = 'default_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $block_id is not named in camelCase. Open
Open
private function add_item($skill, $position)
{
$block_id = $skill['id'];
$end_point = 'readEndpoint';
$class = 'default_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $block_id is not named in camelCase. Open
Open
public function prepare_skill_box($skill, $position, $class)
{
$block_id = $skill['id'];
$extra_class = 'third_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $extra_class is not named in camelCase. Open
Open
public function prepare_skill_box($skill, $position, $class)
{
$block_id = $skill['id'];
$extra_class = 'third_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $my_count is not named in camelCase. Open
Open
public function return_html()
{
if (empty($this->skills)) {
return '';
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $block_id is not named in camelCase. Open
Open
public function prepare_skill_box($skill, $position, $class)
{
$block_id = $skill['id'];
$extra_class = 'third_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $end_point is not named in camelCase. Open
Open
private function add_item($skill, $position)
{
$block_id = $skill['id'];
$end_point = 'readEndpoint';
$class = 'default_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $parent_x is not named in camelCase. Open
Open
public function return_html()
{
if (empty($this->skills)) {
return '';
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $block_id is not named in camelCase. Open
Open
private function add_item($skill, $position)
{
$block_id = $skill['id'];
$end_point = 'readEndpoint';
$class = 'default_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $end_point is not named in camelCase. Open
Open
private function add_item($skill, $position)
{
$block_id = $skill['id'];
$end_point = 'readEndpoint';
$class = 'default_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $block_id is not named in camelCase. Open
Open
public function prepare_skill_box($skill, $position, $class)
{
$block_id = $skill['id'];
$extra_class = 'third_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $block_id is not named in camelCase. Open
Open
public function prepare_skill_box($skill, $position, $class)
{
$block_id = $skill['id'];
$extra_class = 'third_window';- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $skill_count is not named in camelCase. Open
Open
public function return_html()
{
if (empty($this->skills)) {
return '';
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The variable $parent_x is not named in camelCase. Open
Open
public function return_html()
{
if (empty($this->skills)) {
return '';
}- Read upRead up
- Exclude checks
CamelCaseVariableName
Since: 0.2
It is considered best practice to use the camelCase notation to name variables.
Example
class ClassName {
public function doSomething() {
$data_module = new DataModule();
}
}Source
The method prepare_skill_box is not named in camelCase. Open
Open
public function prepare_skill_box($skill, $position, $class)
{
$block_id = $skill['id'];
$extra_class = 'third_window';- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method display_html is not named in camelCase. Open
Open
public function display_html()
{
echo $this->return_html();
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method display_js is not named in camelCase. Open
Open
public function display_js()
{
echo $this->return_js();
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method get_js is not named in camelCase. Open
Open
private function get_js()
{
return $this->js;
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method return_js is not named in camelCase. Open
Open
public function return_js()
{
return $this->get_js();
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method get_html is not named in camelCase. Open
Open
private function get_html()
{
return $this->html;
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method return_html is not named in camelCase. Open
Open
public function return_html()
{
if (empty($this->skills)) {
return '';
}- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method add_item is not named in camelCase. Open
Open
private function add_item($skill, $position)
{
$block_id = $skill['id'];
$end_point = 'readEndpoint';
$class = 'default_window';- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}