The function switch_item_toc() has an NPath complexity of 3168. The configured NPath complexity threshold is 200. Open
function switch_item_toc($lpId, $userId, $viewId, $currentItem, $nextItem)
{
$debug = 0;
$return = '';
if ($debug > 0) {- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
Missing class import via use statement (line '91', column '22'). Open
$myLPI = new learnpathItem($newItemId);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method switch_item_toc uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
if ($debug > 1) {
error_log('In switch_item_details - generating new item object', 0);
}
$myLPI = new learnpathItem($newItemId);- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method switch_item_toc uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$oldItemId = $currentItem;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Consider putting global function "switch_item_toc" in a static class Open
function switch_item_toc($lpId, $userId, $viewId, $currentItem, $nextItem)- Exclude checks
Variable "force_commit" is not in valid camel caps format Open
if ($myLP->force_commit) {- Exclude checks
Variable "use_anonymous" is not in valid camel caps format Open
$use_anonymous = true;- Exclude checks