Missing class import via use statement (line '57', column '67'). Open
$this->metadata = new scormMetadata('manifest', $child);- Read upRead up
- Exclude checks
MissingImport
Since: 2.7.0
Importing all external classes in a file through use statements makes them clearly visible.
Example
function make() {
return new \stdClass();
}Source http://phpmd.org/rules/cleancode.html#MissingImport
The method get_scorm_type uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return '';
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method get_path uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
return '';
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The class scormResource is not named in CamelCase. Open
class scormResource
{
public $identifier = '';
public $type = 'webcontent';
//public $identifierref = '';- Read upRead up
- Exclude checks
CamelCaseClassName
Since: 0.2
It is considered best practice to use the CamelCase notation to name classes.
Example
class class_name {
}Source
Method name "scormResource::get_path" is not in camel caps format Open
public function get_path()- Exclude checks
Missing parameter name Open
* @param mixed Depending on the type given, DB id for the lp_item or reference to the DOM element- Exclude checks
Method name "scormResource::get_scorm_type" is not in camel caps format Open
public function get_scorm_type()- Exclude checks
Spaces must be used for alignment; tabs are not allowed Open
* @author Yannick Warnier <ywarnier@beeznest.org>- Exclude checks
Missing parameter name Open
* @param string Type of construction needed ('db' or 'manifest', default = 'manifest')- Exclude checks
Arguments with default values must be at the end of the argument list Open
public function __construct($type = 'manifest', &$element)- Exclude checks
Class name "scormResource" is not in camel caps format Open
class scormResource- Exclude checks
The method get_path is not named in camelCase. Open
public function get_path()
{
if (!empty($this->href)) {
return Database::escape_string($this->href);
} else {- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}Source
The method get_scorm_type is not named in camelCase. Open
public function get_scorm_type()
{
if (!empty($this->scormtype)) {
return Database::escape_string($this->scormtype);
} else {- Read upRead up
- Exclude checks
CamelCaseMethodName
Since: 0.2
It is considered best practice to use the camelCase notation to name methods.
Example
class ClassName {
public function get_name() {
}
}