The method sendMessage() has an NPath complexity of 384. The configured NPath complexity threshold is 200. Open
public function sendMessage(
int $receiverUserId,
string $subject,
string $content,
array $attachments = [],- Read upRead up
- Exclude checks
NPathComplexity
Since: 0.1
The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.
Example
class Foo {
function bar() {
// lots of complicated code
}
}Source https://phpmd.org/rules/codesize.html#npathcomplexity
The method sendMessage has 13 parameters. Consider reducing the number of parameters to less than 10. Open
public function sendMessage(
int $receiverUserId,
string $subject,
string $content,
array $attachments = [],- Exclude checks
The class MessageHelper has a coupling between objects value of 16. Consider to reduce the number of dependencies under 13. Open
class MessageHelper
{
private ?SessionInterface $session = null;
public function __construct(- Read upRead up
- Exclude checks
CouplingBetweenObjects
Since: 1.1.0
A class with too many dependencies has negative impacts on several quality aspects of a class. This includes quality criteria like stability, maintainability and understandability
Example
class Foo {
/**
* @var \foo\bar\X
*/
private $x = null;
/**
* @var \foo\bar\Y
*/
private $y = null;
/**
* @var \foo\bar\Z
*/
private $z = null;
public function setFoo(\Foo $foo) {}
public function setBar(\Bar $bar) {}
public function setBaz(\Baz $baz) {}
/**
* @return \SplObjectStorage
* @throws \OutOfRangeException
* @throws \InvalidArgumentException
* @throws \ErrorException
*/
public function process(\Iterator $it) {}
// ...
}Source https://phpmd.org/rules/design.html#couplingbetweenobjects
The method sendMessage uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$message = new Message();
$message->setSender($sender)
->addReceiverTo($receiver)
->setTitle($subject)- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
The method processAttachments uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
} else {
$totalFileSize += $size;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Missing class doc comment Open
class MessageHelper- Exclude checks
Add a single space around assignment operators Open
declare(strict_types=1);- Exclude checks
Missing function doc comment Open
public function __construct(- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly MessageRepository $messageRepository,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly UserRepository $userRepository,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly EntityManagerInterface $entityManager,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly RequestStack $requestStack,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly MailerInterface $mailer- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly AccessUrlHelper $accessUrlHelper,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
private readonly SettingsManager $settingsManager,- Exclude checks