src/CoreBundle/State/CToolStateProvider.php
The method provide uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$isAllowToEdit = $isAllowToEditBack;
}- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Avoid unused parameters such as '$key'. Open
Open
fn (int $key, ResourceLink $resourceLink): bool => $resourceLink->getSession()?->getId() === $session->getId()- Read upRead up
- Exclude checks
UnusedFormalParameter
Since: 0.2
Avoid passing parameters to methods or constructors and then not using those parameters.
Example
class Foo
{
private function bar($howdy)
{
// $howdy is not used
}
}Source https://phpmd.org/rules/unusedcode.html#unusedformalparameter
Missing function doc comment Open
Open
public function provide(Operation $operation, array $uriVariables = [], array $context = []): array- Exclude checks
Add a single space around assignment operators Open
Open
declare(strict_types=1);- Exclude checks
Closing brace must be on a line by itself Open
Open
) {}- Exclude checks
Missing function doc comment Open
Open
public function __construct(- Exclude checks
Space before opening parenthesis of function call prohibited Open
Open
fn (int $key, ResourceLink $resourceLink): bool => $resourceLink->getSession()?->getId() === $session->getId()- Exclude checks
Closing brace must be on a line by itself Open
Open
) {}- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly CollectionProvider $provider,- Exclude checks
Space before opening parenthesis of function call prohibited Open
Open
fn (int $key, ResourceLink $resourceLink): bool => $resourceLink->getSession()?->getId() === $session->getId()- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly Security $security,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
protected EntityManagerInterface $entityManager,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly SettingsManager $settingsManager,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
private readonly ToolChain $toolChain,- Exclude checks
Line indented incorrectly; expected 4 spaces, found 8 Open
Open
protected RequestStack $requestStack,- Exclude checks