src/CourseBundle/Repository/CCalendarEventRepository.php
The method createFromAnnouncement uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them. Open
Open
} else {
$sendTo = AbstractResource::separateUsersGroups($users);
if (\is_array($sendTo['groups']) && !empty($sendTo['groups'])) {
$sendTo['groups'] = array_map(- Read upRead up
- Exclude checks
ElseExpression
Since: 1.4.0
An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.
Example
class Foo
{
public function bar($flag)
{
if ($flag) {
// one branch
} else {
// another branch
}
}
}Source https://phpmd.org/rules/cleancode.html#elseexpression
Missing class doc comment Open
Open
final class CCalendarEventRepository extends ResourceRepository- Exclude checks
Missing function doc comment Open
Open
public function __construct(ManagerRegistry $registry)- Exclude checks
Space before opening parenthesis of function call prohibited Open
Open
fn ($userId) => $em->find(User::class, $userId),- Exclude checks
Space before opening parenthesis of function call prohibited Open
Open
fn ($groupId) => $em->find(CGroup::class, $groupId),- Exclude checks
Missing function doc comment Open
Open
public function createFromAnnouncement(- Exclude checks
Add a single space around assignment operators Open
Open
declare(strict_types=1);- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
Open
fn ($userId) => $em->find(User::class, $userId),- Exclude checks
Only one argument is allowed per line in a multi-line function call Open
Open
fn ($groupId) => $em->find(CGroup::class, $groupId),- Exclude checks
Arguments with default values must be at the end of the argument list Open
Open
array $remindersInfo = [],- Exclude checks
Space before opening parenthesis of function call prohibited Open
Open
fn ($groupId) => $em->find(CGroup::class, $groupId),- Exclude checks
Space before opening parenthesis of function call prohibited Open
Open
fn ($userId) => $em->find(User::class, $userId),- Exclude checks