charlotte-ruby/impressionist

View on GitHub

Showing 5 of 5 total issues

File bots.rb has 1465 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module Impressionist
  module Bots

    def self.bot?(user_agent = nil)
      return false if user_agent.nil?
Severity: Major
Found in app/models/impressionist/bots.rb - About 3 days to fix

    Method user_id has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
    Open

        def user_id
          user_id = @current_user ? @current_user.id : nil rescue nil
          user_id = current_user ? current_user.id : nil rescue nil if user_id.blank?
          user_id
        end
    Severity: Minor
    Found in app/controllers/impressionist_controller.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method impressionist_count has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
    Open

        def impressionist_count(options={})
          # Uses these options as defaults unless overridden in options hash
          options.reverse_merge!(:filter => :request_hash, :start_date => nil, :end_date => Time.now)
    
          # If a start_date is provided, finds impressions between then and the end_date. Otherwise returns all impressions
    Severity: Minor
    Found in app/models/impressionist/impressionable.rb - About 55 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method impressionist_subapp_filter has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
    Open

        def impressionist_subapp_filter(opts = {})
          if should_count_impression?(opts)
            actions = opts[:actions]
            actions.collect!{|a|a.to_s} unless actions.blank?
            if (actions.blank? || actions.include?(action_name)) && unique?(opts[:unique])
    Severity: Minor
    Found in app/controllers/impressionist_controller.rb - About 45 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method impressionist has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

        def impressionist(obj,message=nil,opts={})
          if should_count_impression?(opts)
            if obj.respond_to?("impressionable?")
              if unique_instance?(obj, opts[:unique])
                obj.impressions.create(associative_create_statement({:message => message}))
    Severity: Minor
    Found in app/controllers/impressionist_controller.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Severity
    Category
    Status
    Source
    Language