chartmogul/chartmogul-go

View on GitHub
customers_test.go

Summary

Maintainability
C
7 hrs
Test Coverage

Function TestFormattingOfSourceInCustomAttributeUpdate has 62 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestFormattingOfSourceInCustomAttributeUpdate(t *testing.T) {

    expected := map[string]interface{}{
        "attributes": map[string]interface{}{
            "custom": map[string]interface{}{
Severity: Minor
Found in customers_test.go - About 1 hr to fix

    Function TestImportCustomers has 54 lines of code (exceeds 50 allowed). Consider refactoring.
    Open

    func TestImportCustomers(t *testing.T) {
        if !*cm {
            t.SkipNow()
            return
        }
    Severity: Minor
    Found in customers_test.go - About 1 hr to fix

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          server := httptest.NewServer(
              http.HandlerFunc(
                  func(w http.ResponseWriter, r *http.Request) {
                      if r.Method != "GET" {
                          t.Errorf("Unexpected method %v", r.Method)
      Severity: Major
      Found in customers_test.go and 3 other locations - About 1 hr to fix
      customers_test.go on lines 284..301
      metrics_activities_exports_test.go on lines 13..39
      metrics_activities_exports_test.go on lines 65..91

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 141.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 4 locations. Consider refactoring.
      Open

          server := httptest.NewServer(
              http.HandlerFunc(
                  func(w http.ResponseWriter, r *http.Request) {
                      if r.Method != "GET" {
                          t.Errorf("Unexpected method %v", r.Method)
      Severity: Major
      Found in customers_test.go and 3 other locations - About 1 hr to fix
      customers_test.go on lines 250..263
      metrics_activities_exports_test.go on lines 13..39
      metrics_activities_exports_test.go on lines 65..91

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 141.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          server := httptest.NewServer(
              http.HandlerFunc(
                  func(w http.ResponseWriter, r *http.Request) {
                      if r.Method != "DELETE" {
                          t.Errorf("Unexpected method %v", r.Method)
      Severity: Major
      Found in customers_test.go and 2 other locations - About 55 mins to fix
      customers_test.go on lines 149..159
      customers_test.go on lines 206..216

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          server := httptest.NewServer(
              http.HandlerFunc(
                  func(w http.ResponseWriter, r *http.Request) {
                      if r.Method != "DELETE" {
                          t.Errorf("Unexpected method %v", r.Method)
      Severity: Major
      Found in customers_test.go and 2 other locations - About 55 mins to fix
      customers_test.go on lines 149..159
      customers_test.go on lines 176..186

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 3 locations. Consider refactoring.
      Open

          server := httptest.NewServer(
              http.HandlerFunc(
                  func(w http.ResponseWriter, r *http.Request) {
                      if r.Method != "DELETE" {
                          t.Errorf("Unexpected method %v", r.Method)
      Severity: Major
      Found in customers_test.go and 2 other locations - About 55 mins to fix
      customers_test.go on lines 176..186
      customers_test.go on lines 206..216

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 124.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status