Sign upLogin

chartmogul/chartmogul-go

View on GitHub
Star

Showing 38 of 38 total issues

Similar blocks of code found in 4 locations. Consider refactoring.
Open

    server := httptest.NewServer(
        http.HandlerFunc(
            func(w http.ResponseWriter, r *http.Request) {
                if r.Method != "GET" {
                    t.Errorf("Unexpected method %v", r.Method)
Severity: Major
Found in customers_test.go and 3 other locations - About 1 hr to fix
customers_test.go on lines 250..263
metrics_activities_exports_test.go on lines 13..39
metrics_activities_exports_test.go on lines 65..91

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 141.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Function TestImportCustomers has 54 lines of code (exceeds 50 allowed). Consider refactoring.
Open

func TestImportCustomers(t *testing.T) {
    if !*cm {
        t.SkipNow()
        return
    }
Severity: Minor
Found in customers_test.go - About 1 hr to fix

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    func (api API) MetricsListSubscriptions(cursor *Cursor, customerUUID string) (*MetricsSubscriptions, error) {
    result := &MetricsSubscriptions{}
    path := strings.Replace(metricsSubscriptionsEndpoint, ":uuid", customerUUID, 1)
    query := make([]interface{}, 0, 1)
    if cursor != nil {
    Severity: Major
    Found in metrics_subscriptions.go and 3 other locations - About 55 mins to fix
    invoices.go on lines 85..93
    metrics_activities.go on lines 31..39
    subscriptions.go on lines 50..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 124.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        server := httptest.NewServer(
        http.HandlerFunc(
            func(w http.ResponseWriter, r *http.Request) {
                if r.Method != "DELETE" {
                    t.Errorf("Unexpected method %v", r.Method)
    Severity: Major
    Found in customers_test.go and 2 other locations - About 55 mins to fix
    customers_test.go on lines 149..159
    customers_test.go on lines 206..216

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 124.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    func (api API) MetricsListActivities(cursor *Cursor, customerUUID string) (*MetricsActivities, error) {
    result := &MetricsActivities{}
    path := strings.Replace(metricsActivitiesEndpoint, ":uuid", customerUUID, 1)
    query := make([]interface{}, 0, 1)
    if cursor != nil {
    Severity: Major
    Found in metrics_activities.go and 3 other locations - About 55 mins to fix
    invoices.go on lines 85..93
    metrics_subscriptions.go on lines 35..43
    subscriptions.go on lines 50..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 124.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        server := httptest.NewServer(
        http.HandlerFunc(
            func(w http.ResponseWriter, r *http.Request) {
                if r.Method != "DELETE" {
                    t.Errorf("Unexpected method %v", r.Method)
    Severity: Major
    Found in customers_test.go and 2 other locations - About 55 mins to fix
    customers_test.go on lines 149..159
    customers_test.go on lines 176..186

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 124.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 3 locations. Consider refactoring.
    Open

        server := httptest.NewServer(
        http.HandlerFunc(
            func(w http.ResponseWriter, r *http.Request) {
                if r.Method != "DELETE" {
                    t.Errorf("Unexpected method %v", r.Method)
    Severity: Major
    Found in customers_test.go and 2 other locations - About 55 mins to fix
    customers_test.go on lines 176..186
    customers_test.go on lines 206..216

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 124.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    func (api API) ListInvoices(cursor *Cursor, customerUUID string) (*Invoices, error) {
    result := &Invoices{}
    path := strings.Replace(customersInvoicesEndpoint, ":customerUUID", customerUUID, 1)
    query := make([]interface{}, 0, 1)
    if cursor != nil {
    Severity: Major
    Found in invoices.go and 3 other locations - About 55 mins to fix
    metrics_activities.go on lines 31..39
    metrics_subscriptions.go on lines 35..43
    subscriptions.go on lines 50..58

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 124.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 4 locations. Consider refactoring.
    Open

    func (api API) ListSubscriptions(cursor *Cursor, customerUUID string) (*Subscriptions, error) {
    result := &Subscriptions{}
    path := strings.Replace(subscriptionsEndpoint, ":customerUUID", customerUUID, 1)
    query := make([]interface{}, 0, 1)
    if cursor != nil {
    Severity: Major
    Found in subscriptions.go and 3 other locations - About 55 mins to fix
    invoices.go on lines 85..93
    metrics_activities.go on lines 31..39
    metrics_subscriptions.go on lines 35..43

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 124.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Method API.updateImpl has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

    func (api API) updateImpl(path string, uuid string, input interface{}, output interface{}, method string) error {
    Severity: Minor
    Found in generic.go - About 35 mins to fix

      Method Errors.IsInvoiceAndItsEntitiesAlreadyExist has 5 return statements (exceeds 4 allowed).
      Open

      func (e Errors) IsInvoiceAndItsEntitiesAlreadyExist() (is bool) {
    if e == nil {
        return
    }
    if msg := e[ErrKeyExternalID]; msg != ErrValInvoiceExternalIDExists {
      Severity: Major
      Found in chartmogul.go - About 35 mins to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            backoff.Retry(func() error {
        res, body, errs = api.req(gorequest.New().Delete(prepareURL(path))).
            SendStruct(input).
            EndStruct(output)
        Severity: Minor
        Found in generic.go and 1 other location - About 35 mins to fix
        generic.go on lines 29..39

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            backoff.Retry(func() error {
        res, body, errs = api.req(gorequest.New().
            Post(prepareURL(path))).
            SendStruct(input).
            EndStruct(output)
        Severity: Minor
        Found in generic.go and 1 other location - About 35 mins to fix
        generic.go on lines 188..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 104.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (api API) ListPlans(listPlansParams *ListPlansParams) (*Plans, error) {
    result := &Plans{}
    query := make([]interface{}, 0, 1)
    if listPlansParams != nil {
        query = append(query, *listPlansParams)
        Severity: Minor
        Found in plans.go and 2 other locations - About 35 mins to fix
        customers.go on lines 189..196
        plan_groups.go on lines 43..50

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (api API) ListCustomers(listCustomersParams *ListCustomersParams) (*Customers, error) {
    result := &Customers{}
    query := make([]interface{}, 0, 1)
    if listCustomersParams != nil {
        query = append(query, *listCustomersParams)
        Severity: Minor
        Found in customers.go and 2 other locations - About 35 mins to fix
        plan_groups.go on lines 43..50
        plans.go on lines 53..60

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        func (api API) ListPlanGroups(cursor *Cursor) (*PlanGroups, error) {
    result := &PlanGroups{}
    query := make([]interface{}, 0, 1)
    if cursor != nil {
        query = append(query, *cursor)
        Severity: Minor
        Found in plan_groups.go and 2 other locations - About 35 mins to fix
        customers.go on lines 189..196
        plans.go on lines 53..60

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 103.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        // Package chartmogul is a simple Go API library for Chartmogul public API.
        Severity: Minor
        Found in chartmogul.go by gofmt

        Your code does not pass gofmt in 1 place. Go fmt your code!
        Open

        package chartmogul
        Severity: Minor
        Found in errors.go by gofmt
        Severity
        Category
        Status
        Source
        Language