Sign upLogin

chef-cookbooks/httpd

View on GitHub
Star
libraries/info_module_packages.rb

Summary

Maintainability
C
1 day
Test Coverage

File info_module_packages.rb has 329 lines of code (exceeds 250 allowed). Consider refactoring.
Open

module HttpdCookbook
  module Helpers
    module ModuleInfoDSL
      # create big crash hash with other hashes as keys
      # {:platform=>"amazon", :httpd_version=>"2.4", :module=>"rev"}=>"mod_revocator",
Severity: Minor
Found in libraries/info_module_packages.rb - About 3 hrs to fix

    Method package_name_for_module has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def package_name_for_module(name, httpd_version, platform, platform_family, platform_version)
    Severity: Minor
    Found in libraries/info_module_packages.rb - About 35 mins to fix

      Method platform_version_key has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def platform_version_key(platform, platform_family, platform_version)
      return platform_version.to_i.to_s if platform_family == 'rhel' && platform != 'amazon'
      return platform_version.to_i.to_s if platform_family == 'debian' && !(platform == 'ubuntu' || platform_version =~ /sid$/)
      return platform_version.to_i.to_s if platform_family == 'freebsd'
      platform_version
      Severity: Minor
      Found in libraries/info_module_packages.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                    are: %w(
                access_compat actions alias allowmethods asis auth_basic
                auth_digest authn_anon authn_core authn_dbd authn_dbm authn_file
                authn_socache authz_core authz_dbd authz_dbm authz_groupfile
                authz_host authz_owner authz_user autoindex buffer cache cache_disk
      Severity: Major
      Found in libraries/info_module_packages.rb and 1 other location - About 2 hrs to fix
      libraries/info_module_packages.rb on lines 160..176

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                    are: %w(
                access_compat actions alias allowmethods asis auth_basic
                auth_digest authn_anon authn_core authn_dbd authn_dbm authn_file
                authn_socache authz_core authz_dbd authz_dbm authz_groupfile
                authz_host authz_owner authz_user autoindex buffer cache cache_disk
      Severity: Major
      Found in libraries/info_module_packages.rb and 1 other location - About 2 hrs to fix
      libraries/info_module_packages.rb on lines 221..237

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 101.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            modules for: { platform_family: 'rhel', platform_version: '6', httpd_version: '2.2' },
              are: %w(
                auth_kerb auth_mysql auth_pgsql authz_ldap dav_svn dnssd nss
                perl revocator ssl wsgi
              ),
      Severity: Minor
      Found in libraries/info_module_packages.rb and 1 other location - About 25 mins to fix
      libraries/info_module_packages.rb on lines 181..188

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

            modules for: { platform_family: 'rhel', platform_version: '7', httpd_version: '2.4' },
              are: %w(
                auth_kerb dav_svn fcgid ldap nss proxy_html revocator security
                session ssl wsgi
              ),
      Severity: Minor
      Found in libraries/info_module_packages.rb and 1 other location - About 25 mins to fix
      libraries/info_module_packages.rb on lines 135..142

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 30.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status