chef/supermarket

View on GitHub
omnibus/cookbooks/omnibus-supermarket/libraries/config.rb

Summary

Maintainability
A
1 hr
Test Coverage

Method audit_s3_config has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    def self.audit_s3_config(config)
      required_s3_vars = %w(s3_bucket s3_region).freeze
      any_required_s3_vars = required_s3_vars.any? { |key| !config[key].nil? }
      all_required_s3_vars = required_s3_vars.all? { |key| !(config[key].nil? || config[key].empty?) }

Severity: Minor
Found in omnibus/cookbooks/omnibus-supermarket/libraries/config.rb - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method load_or_create_secrets! has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
Open

    def self.load_or_create_secrets!(filename, node)
      create_directory!(filename)
      secrets = Chef::JSONCompat.from_json(File.open(filename).read)
      node.consume_attributes('supermarket' => secrets)
    rescue Errno::ENOENT
Severity: Minor
Found in omnibus/cookbooks/omnibus-supermarket/libraries/config.rb - About 35 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method audit_fips_config has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
Open

    def self.audit_fips_config(config)
      unless built_with_fips?(config['install_directory'])
        if fips_enabled_in_kernel?
          raise IncompatibleConfig, 'Detected FIPS is enabled in the kernel, but FIPS is not supported by this installer.'
        end
Severity: Minor
Found in omnibus/cookbooks/omnibus-supermarket/libraries/config.rb - About 25 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

There are no issues that match your filters.

Category
Status