chef/supermarket

View on GitHub
src/supermarket/app/controllers/api/v1/cookbook_uploads_controller.rb

Summary

Maintainability
A
3 hrs
Test Coverage

Method authenticate_user! has 35 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def authenticate_user!
    username = request.headers['X-Ops-Userid']
    user = Account.for('chef_oauth2').where(username: username).first.try(:user)

    unless user

    Method create has 26 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def create
        cookbook_upload = CookbookUpload.new(current_user, upload_params)
    
        begin
          authorize! cookbook_upload.cookbook

      Method create has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def create
          cookbook_upload = CookbookUpload.new(current_user, upload_params)
      
          begin
            authorize! cookbook_upload.cookbook
      Severity: Minor
      Found in src/supermarket/app/controllers/api/v1/cookbook_uploads_controller.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      There are no issues that match your filters.

      Category
      Status