chippyash/Builder-Pattern

View on GitHub
src/Chippyash/BuilderPattern/Renderer/XmlRenderer.php

Summary

Maintainability
B
4 hrs
Test Coverage

Function encodeObject has a Cognitive Complexity of 16 (exceeds 5 allowed). Consider refactoring.
Open

    protected function encodeObject($key, $value, \DOMDocument $dom, \DOMElement $node) 
    {
        if (method_exists($value, '__toString')) {
            $node->appendChild($dom->createElement($key, (string) $value));
        } elseif (method_exists($value, 'toString')) {
Severity: Minor
Found in src/Chippyash/BuilderPattern/Renderer/XmlRenderer.php - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function arrayToDomNode has a Cognitive Complexity of 14 (exceeds 5 allowed). Consider refactoring.
Open

    protected function arrayToDomNode(\DOMDocument $dom, \DOMElement $node, array $arr)
    {
        foreach ($arr as $key => $item) {
            $ref = null;
            if (is_numeric($key) || empty($key)) {
Severity: Minor
Found in src/Chippyash/BuilderPattern/Renderer/XmlRenderer.php - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Method encodeObject has 28 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    protected function encodeObject($key, $value, \DOMDocument $dom, \DOMElement $node) 
    {
        if (method_exists($value, '__toString')) {
            $node->appendChild($dom->createElement($key, (string) $value));
        } elseif (method_exists($value, 'toString')) {
Severity: Minor
Found in src/Chippyash/BuilderPattern/Renderer/XmlRenderer.php - About 1 hr to fix

    There are no issues that match your filters.

    Category
    Status