chippyash/Currency

View on GitHub

Showing 143 of 146 total issues

Method main has 79 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function main()
{
    $dataDir = realpath(__DIR__ . '/../data');

    $fSymbols = new DOMDocument();
Severity: Major
Found in bin/create-currency-data.php - About 3 hrs to fix

    Function main has a Cognitive Complexity of 21 (exceeds 5 allowed). Consider refactoring.
    Open

    function main()
    {
        $dataDir = realpath(__DIR__ . '/../data');
    
        $fSymbols = new DOMDocument();
    Severity: Minor
    Found in bin/create-currency-data.php - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Missing class import via use statement (line '71', column '17').
    Open

        $fIso = new DOMDocument();
    Severity: Minor
    Found in bin/create-currency-data.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '75', column '17').
    Open

        $qIso = new DOMXPath($fIso);
    Severity: Minor
    Found in bin/create-currency-data.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '136', column '18').
    Open

            $q = new DOMXPath($dom);
    Severity: Minor
    Found in bin/create-currency-data.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '77', column '17').
    Open

        $fOut = new DOMDocument('1.0', 'UTF-8');
    Severity: Minor
    Found in bin/create-currency-data.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '134', column '20').
    Open

            $dom = new DOMDocument();
    Severity: Minor
    Found in bin/create-currency-data.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '223', column '23').
    Open

                throw new \InvalidArgumentException('value is not numeric');
    Severity: Minor
    Found in src/Chippyash/Currency/Currency.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '74', column '21').
    Open

        $qSymbols = new DOMXPath($fSymbols);
    Severity: Minor
    Found in bin/create-currency-data.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '266', column '26').
    Open

            $formatter = new \NumberFormatter($this->locale, \NumberFormatter::CURRENCY);
    Severity: Minor
    Found in src/Chippyash/Currency/Currency.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '68', column '21').
    Open

        $fSymbols = new DOMDocument();
    Severity: Minor
    Found in bin/create-currency-data.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '89', column '23').
    Open

                throw new \InvalidArgumentException("Unknown currency: {$code}");
    Severity: Minor
    Found in src/Chippyash/Currency/Factory.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '128', column '17').
    Open

        $qOut = new DOMXPath($fOut);
    Severity: Minor
    Found in bin/create-currency-data.php by phpmd

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Missing class import via use statement (line '42', column '21').
    Open

            $refl = new \ReflectionClass($crcy);

    MissingImport

    Since: 2.7.0

    Importing all external classes in a file through use statements makes them clearly visible.

    Example

    function make() {
        return new \stdClass();
    }

    Source http://phpmd.org/rules/cleancode.html#MissingImport

    Avoid using static access to class '\Chippyash\Currency\Factory' in method 'setBuildItems'.
    Open

            $crcy = Factory::create($this->code);

    StaticAccess

    Since: 1.4.0

    Static access causes unexchangeable dependencies to other classes and leads to hard to test code. Avoid using static access at all costs and instead inject dependencies through the constructor. The only case when static access is acceptable is when used for factory methods.

    Example

    class Foo
    {
        public function bar()
        {
            Bar::baz();
        }
    }

    Source https://phpmd.org/rules/cleancode.html#staticaccess

    The function main() has 105 lines of code. Current threshold is set to 100. Avoid really long methods.
    Open

    function main()
    {
        $dataDir = realpath(__DIR__ . '/../data');
    
        $fSymbols = new DOMDocument();
    Severity: Minor
    Found in bin/create-currency-data.php by phpmd

    The method main uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
    Open

            } else {
                echo "No symbol found for: {$cCode}\n";
            }
    Severity: Minor
    Found in bin/create-currency-data.php by phpmd

    ElseExpression

    Since: 1.4.0

    An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

    Example

    class Foo
    {
        public function bar($flag)
        {
            if ($flag) {
                // one branch
            } else {
                // another branch
            }
        }
    }

    Source https://phpmd.org/rules/cleancode.html#elseexpression

    The function main() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
    Open

    function main()
    {
        $dataDir = realpath(__DIR__ . '/../data');
    
        $fSymbols = new DOMDocument();
    Severity: Minor
    Found in bin/create-currency-data.php by phpmd

    CyclomaticComplexity

    Since: 0.1

    Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

    Example

    // Cyclomatic Complexity = 11
    class Foo {
    1   public function example() {
    2       if ($a == $b) {
    3           if ($a1 == $b1) {
                    fiddle();
    4           } elseif ($a2 == $b2) {
                    fiddle();
                } else {
                    fiddle();
                }
    5       } elseif ($c == $d) {
    6           while ($c == $d) {
                    fiddle();
                }
    7        } elseif ($e == $f) {
    8           for ($n = 0; $n < $h; $n++) {
                    fiddle();
                }
            } else {
                switch ($z) {
    9               case 1:
                        fiddle();
                        break;
    10              case 2:
                        fiddle();
                        break;
    11              case 3:
                        fiddle();
                        break;
                    default:
                        fiddle();
                        break;
                }
            }
        }
    }

    Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

    XXX found
    Open

        <currency code="XXX" number="999">
    Severity: Minor
    Found in src/Chippyash/Currency/currencies.xml by fixme

    XXX found
    Open

                <currency type="XXX">
    Severity: Minor
    Found in data/cldr/de.xml by fixme
    Severity
    Category
    Status
    Source
    Language