chippyash/Math-Type-Calculator

View on GitHub
src/Chippyash/Math/Type/Traits/ArbitrateTwoTypes.php

Summary

Maintainability
A
1 hr
Test Coverage

Function arbitrate has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
Open

    protected function arbitrate(NumericTypeInterface $a, NumericTypeInterface $b)
    {
        $pairing = $this->getTypePairing($a, $b);
        if ($pairing == 'complex:complex') {
            return 'complex';
Severity: Minor
Found in src/Chippyash/Math/Type/Traits/ArbitrateTwoTypes.php - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this method.
Open

            return 'float';
Severity: Major
Found in src/Chippyash/Math/Type/Traits/ArbitrateTwoTypes.php - About 30 mins to fix

    Avoid too many return statements within this method.
    Open

                return 'whole';
    Severity: Major
    Found in src/Chippyash/Math/Type/Traits/ArbitrateTwoTypes.php - About 30 mins to fix

      Avoid too many return statements within this method.
      Wontfix

                  return 'int';
      Severity: Major
      Found in src/Chippyash/Math/Type/Traits/ArbitrateTwoTypes.php - About 30 mins to fix

        Avoid too many return statements within this method.
        Wontfix

                    return 'natural';
        Severity: Major
        Found in src/Chippyash/Math/Type/Traits/ArbitrateTwoTypes.php - About 30 mins to fix

          The method arbitrate() has an NPath complexity of 256. The configured NPath complexity threshold is 200.
          Open

              protected function arbitrate(NumericTypeInterface $a, NumericTypeInterface $b)
              {
                  $pairing = $this->getTypePairing($a, $b);
                  if ($pairing == 'complex:complex') {
                      return 'complex';

          NPathComplexity

          Since: 0.1

          The NPath complexity of a method is the number of acyclic execution paths through that method. A threshold of 200 is generally considered the point where measures should be taken to reduce complexity.

          Example

          class Foo {
              function bar() {
                  // lots of complicated code
              }
          }

          Source https://phpmd.org/rules/codesize.html#npathcomplexity

          There are no issues that match your filters.

          Category
          Status