chippyash/Monad

View on GitHub

Showing 30 of 30 total issues

Collection has 27 functions (exceeds 20 allowed). Consider refactoring.
Open

class Collection extends ArrayObject implements Monadic
{

    /**
     * The Type of the items in the collection
Severity: Minor
Found in src/chippyash/Monad/Collection.php - About 3 hrs to fix

    File Collection.php has 266 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    /**
     * Monad
     *
     * @author Ashley Kitson
    Severity: Minor
    Found in src/chippyash/Monad/Collection.php - About 2 hrs to fix

      Method setTypeFromValue has 59 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

          protected function setTypeFromValue(array $value): FTry
          {
              //required to be defined as a var so it can be called in next statement
              $basicTest = function () use ($value) {
                  if (count($value) > 0) {
      Severity: Major
      Found in src/chippyash/Monad/Collection.php - About 2 hrs to fix

        Method matchOnNative has 38 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

            protected function matchOnNative($name): bool
            {
                switch(strtolower($name)) {
                    case 'string':
                        return is_string($this->value);
        Severity: Minor
        Found in src/chippyash/Monad/FMatch.php - About 1 hr to fix

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public function vIntersect(Collection $other, \Closure $function = null)
              {
                  if (is_null($function)) {
                      return new static(\array_intersect($this->getArrayCopy(), $other->getArrayCopy()), $this->type);
                  }
          Severity: Major
          Found in src/chippyash/Monad/Collection.php and 2 other locations - About 1 hr to fix
          src/chippyash/Monad/Collection.php on lines 262..269
          src/chippyash/Monad/Collection.php on lines 288..295

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public function vDiff(Collection $other, \Closure $function = null)
              {
                  if (is_null($function)) {
                      return new static(\array_diff($this->getArrayCopy(), $other->getArrayCopy()), $this->type);
                  }
          Severity: Major
          Found in src/chippyash/Monad/Collection.php and 2 other locations - About 1 hr to fix
          src/chippyash/Monad/Collection.php on lines 288..295
          src/chippyash/Monad/Collection.php on lines 324..331

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Similar blocks of code found in 3 locations. Consider refactoring.
          Open

              public function kDiff(Collection $other, \Closure $function = null)
              {
                  if (is_null($function)) {
                      return new static(\array_diff_key($this->getArrayCopy(), $other->getArrayCopy()), $this->type);
                  }
          Severity: Major
          Found in src/chippyash/Monad/Collection.php and 2 other locations - About 1 hr to fix
          src/chippyash/Monad/Collection.php on lines 262..269
          src/chippyash/Monad/Collection.php on lines 324..331

          Duplicated Code

          Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

          Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

          When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

          Tuning

          This issue has a mass of 100.

          We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

          The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

          If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

          See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

          Refactorings

          Further Reading

          Function __call has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
          Open

              public function __call($method, $args): FMatch
              {
                  if ($this->isMatched) {
                      return new static($this->value, $this->isMatched);
                  }
          Severity: Minor
          Found in src/chippyash/Monad/FMatch.php - About 55 mins to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                          return is_array($this->value);
          Severity: Major
          Found in src/chippyash/Monad/FMatch.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                return new None();
            Severity: Major
            Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                                              return new Some($v);
              Severity: Major
              Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

                Avoid too many return statements within this method.
                Open

                                return is_object($this->value);
                Severity: Major
                Found in src/chippyash/Monad/FMatch.php - About 30 mins to fix

                  Avoid too many return statements within this method.
                  Open

                                  return is_dir($this->value);
                  Severity: Major
                  Found in src/chippyash/Monad/FMatch.php - About 30 mins to fix

                    Avoid too many return statements within this method.
                    Open

                                                    return new Some($v);
                    Severity: Major
                    Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

                      Avoid too many return statements within this method.
                      Open

                                                      return new None();
                      Severity: Major
                      Found in src/chippyash/Monad/Collection.php - About 30 mins to fix

                        Avoid too many return statements within this method.
                        Open

                                        return is_resource($this->value);
                        Severity: Major
                        Found in src/chippyash/Monad/FMatch.php - About 30 mins to fix

                          Avoid too many return statements within this method.
                          Open

                                  return new static($this->value);
                          Severity: Major
                          Found in src/chippyash/Monad/FMatch.php - About 30 mins to fix

                            Avoid too many return statements within this method.
                            Open

                                            return is_file($this->value);
                            Severity: Major
                            Found in src/chippyash/Monad/FMatch.php - About 30 mins to fix

                              Avoid too many return statements within this method.
                              Open

                                          return new Failure($e);
                              Severity: Major
                              Found in src/chippyash/Monad/FTry.php - About 30 mins to fix

                                Avoid too many return statements within this method.
                                Open

                                                return is_bool($this->value);
                                Severity: Major
                                Found in src/chippyash/Monad/FMatch.php - About 30 mins to fix
                                  Severity
                                  Category
                                  Status
                                  Source
                                  Language