chippyash/Simple-Accounts

Method buildTree has 27 lines of code (exceeds 25 allowed). Consider refactoring.

Open

    protected function buildTree(Node $tree, \DOMNode $node, Chart $chart, array $accountTypes)
    {
        //create current node
        list($nominal, $type, $name, $id) = FFor::create()
            ->attributes(function () use ($node) {

Avoid too many return statements within this method.

Open

                return new IntType($attributes->getNamedItem('id')->nodeValue);

The class Accountant has a coupling between objects value of 27. Consider to reduce the number of dependencies under 13.

Open

class Accountant
{
    /**@+
     * Error strings
     */

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Foo {
    /**
     * @var \foo\bar\X
     */
    private $x = null;

    /**
     * @var \foo\bar\Y
     */
    private $y = null;

    /**
     * @var \foo\bar\Z
     */
    private $z = null;

    public function setFoo(\Foo $foo) {}
    public function setBar(\Bar $bar) {}
    public function setBaz(\Baz $baz) {}

    /**
     * @return \SplObjectStorage
     * @throws \OutOfRangeException
     * @throws \InvalidArgumentException
     * @throws \ErrorException
     */
    public function process(\Iterator $it) {}

    // ...
}

Missing class import via use statement (line '63', column '28').

Open

                return new \DOMXPath($dom);

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

function make() {
    return new \stdClass();
}

Avoid variables with short names like $id. Configured minimum length is 3.

Open

        list($nominal, $type, $name, $id) = FFor::create()

• Read up
  Read up
• Exclude checks
  • Disable engine
  • Disable check

class Something {
    private $q = 15; // VIOLATION - Field
    public static function main( array $as ) { // VIOLATION - Formal
        $r = 20 + $this->q; // VIOLATION - Local
        for (int $i = 0; $i < 10; $i++) { // Not a Violation (inside FOR)
            $r += $this->q;
        }
    }
}