chris-kruining/utilities

View on GitHub

Showing 43 of 43 total issues

Collection has 92 functions (exceeds 20 allowed). Consider refactoring.
Open

    class Collection implements CollectionInterface
    {
        protected
            $items
        ;
Severity: Major
Found in src/Collections/Collection.php - About 1 day to fix

    File Collection.php has 744 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    <?php
    
    namespace CPB\Utilities\Collections
    {
        use Core\Utility\Exception\Deprecated;
    Severity: Major
    Found in src/Collections/Collection.php - About 1 day to fix

      Function split has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring.
      Open

              private function split(string $query): Collection
              {
                  $out = [];
                  $pos = 0;
              
      Severity: Minor
      Found in src/Parser/Expression.php - About 4 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      File Expression.php has 324 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      <?php
      
      namespace CPB\Utilities\Parser
      {
          use CPB\Utilities\Collections\Collection;
      Severity: Minor
      Found in src/Parser/Expression.php - About 3 hrs to fix

        Method split has 86 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                private function split(string $query): Collection
                {
                    $out = [];
                    $pos = 0;
                
        Severity: Major
        Found in src/Parser/Expression.php - About 3 hrs to fix

          File Table.php has 285 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          <?php
          
          namespace CPB\Utilities\Collections
          {
              use Core\Utility\Exception\NotImplemented;
          Severity: Minor
          Found in src/Collections/Table.php - About 2 hrs to fix

            Method join has 66 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

                    public function join(
                        iterable $iterable,
                        string $localKey,
                        string $foreignKey,
                        JoinStrategy $strategy = null
            Severity: Major
            Found in src/Collections/Table.php - About 2 hrs to fix

              Method parseOperator has 60 lines of code (exceeds 25 allowed). Consider refactoring.
              Open

                      private function parseOperator($left, ?string $operator, $right)
                      {
                          switch($operator)
                          {
                              // NOTE(Chris Kruining)
              Severity: Major
              Found in src/Parser/Expression.php - About 2 hrs to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        public function max(string $key = null, float $limit = null)
                        {
                            $result = $this->columnAction('max', $key ?? '');
                
                            if($limit !== null)
                Severity: Major
                Found in src/Collections/Map.php and 1 other location - About 2 hrs to fix
                src/Collections/Map.php on lines 90..107

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                        public function min(string $key = null, float $limit = null)
                        {
                            $result = $this->columnAction('min', $key ?? '');
                
                            if($limit !== null)
                Severity: Major
                Found in src/Collections/Map.php and 1 other location - About 2 hrs to fix
                src/Collections/Map.php on lines 66..83

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 106.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Method __get has 44 lines of code (exceeds 25 allowed). Consider refactoring.
                Open

                        public function __get($name)
                        {
                            switch($name)
                            {
                                case 'years':
                Severity: Minor
                Found in src/Common/DateRange.php - About 1 hr to fix

                  Method resolveKey has 43 lines of code (exceeds 25 allowed). Consider refactoring.
                  Open

                          private function resolveKey($key)
                          {
                              $trimmed = \trim($key);
                          
                              if(\strlen($trimmed) === 0)
                  Severity: Minor
                  Found in src/Parser/Expression.php - About 1 hr to fix

                    Function offsetGet has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
                    Open

                            public function offsetGet($offset)
                            {
                                if((\is_string($offset) || \is_numeric($offset)) && \key_exists($offset, $this->items))
                                {
                                    return $this->items[$offset];
                    Severity: Minor
                    Found in src/Collections/Collection.php - About 1 hr to fix

                    Cognitive Complexity

                    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                    A method's cognitive complexity is based on a few simple rules:

                    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                    • Code is considered more complex for each "break in the linear flow of the code"
                    • Code is considered more complex when "flow breaking structures are nested"

                    Further reading

                    Method offsetGet has 35 lines of code (exceeds 25 allowed). Consider refactoring.
                    Open

                            public function offsetGet($offset)
                            {
                                if((\is_string($offset) || \is_numeric($offset)) && \key_exists($offset, $this->items))
                                {
                                    return $this->items[$offset];
                    Severity: Minor
                    Found in src/Collections/Collection.php - About 1 hr to fix

                      Function parseParameters has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring.
                      Open

                              private function parseParameters(string $parameters): Collection
                              {
                                  $out = [];
                                  $pos = 0;
                                  $level = 0;
                      Severity: Minor
                      Found in src/Parser/Expression.php - About 1 hr to fix

                      Cognitive Complexity

                      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                      A method's cognitive complexity is based on a few simple rules:

                      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                      • Code is considered more complex for each "break in the linear flow of the code"
                      • Code is considered more complex when "flow breaking structures are nested"

                      Further reading

                      Method has has 30 lines of code (exceeds 25 allowed). Consider refactoring.
                      Open

                              public function has($key, string ...$keys): bool
                              {
                                  \array_unshift($keys, $key);
                                  
                                  return $this->some(function($i, $row) use($keys){
                      Severity: Minor
                      Found in src/Collections/Table.php - About 1 hr to fix

                        Method parseParameters has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                        Open

                                private function parseParameters(string $parameters): Collection
                                {
                                    $out = [];
                                    $pos = 0;
                                    $level = 0;
                        Severity: Minor
                        Found in src/Parser/Expression.php - About 1 hr to fix

                          Method get has 29 lines of code (exceeds 25 allowed). Consider refactoring.
                          Open

                                  public function get($key, string ...$keys): Resolvable
                                  {
                                      \array_unshift($keys, $key);
                                      
                                      if(!$this->has(...$keys))
                          Severity: Minor
                          Found in src/Collections/Table.php - About 1 hr to fix

                            Function each has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                            Open

                                    public function each(callable $callback): CollectionInterface
                                    {
                                        $collection = [];
                            
                                        foreach($this->items as $key => $value)
                            Severity: Minor
                            Found in src/Collections/Collection.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Function offsetSet has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
                            Open

                                    public function offsetSet($offset, $value)
                                    {
                                        switch(\gettype($offset))
                                        {
                                            case 'string':
                            Severity: Minor
                            Found in src/Collections/Collection.php - About 1 hr to fix

                            Cognitive Complexity

                            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

                            A method's cognitive complexity is based on a few simple rules:

                            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
                            • Code is considered more complex for each "break in the linear flow of the code"
                            • Code is considered more complex when "flow breaking structures are nested"

                            Further reading

                            Severity
                            Category
                            Status
                            Source
                            Language