Showing 42 of 42 total issues
Collection
has 92 functions (exceeds 20 allowed). Consider refactoring. Open
class Collection implements CollectionInterface
{
protected
$items
;
File Collection.php
has 735 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace CPB\Utilities\Collections
{
use Core\Utility\Exception\Deprecated;
Function split
has a Cognitive Complexity of 33 (exceeds 5 allowed). Consider refactoring. Open
private function split(string $query): Collection
{
$out = [];
$pos = 0;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File Expression.php
has 324 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace CPB\Utilities\Parser
{
use CPB\Utilities\Collections\Collection;
Method split
has 86 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function split(string $query): Collection
{
$out = [];
$pos = 0;
File Table.php
has 279 lines of code (exceeds 250 allowed). Consider refactoring. Open
<?php
namespace CPB\Utilities\Collections
{
use Core\Utility\Exception\NotImplemented;
Method parseOperator
has 60 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function parseOperator($left, ?string $operator, $right)
{
switch($operator)
{
// NOTE(Chris Kruining)
Method join
has 60 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function join(
iterable $iterable,
string $localKey,
string $foreignKey,
JoinStrategy $strategy = null
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function min(string $key = null, float $limit = null)
{
$result = $this->columnAction('min', $key ?? '');
if($limit !== null)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 122.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
public function max(string $key = null, float $limit = null)
{
$result = $this->columnAction('max', $key ?? '');
if($limit !== null)
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 122.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Method __get
has 44 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function __get($name)
{
switch($name)
{
case 'years':
Method resolveKey
has 43 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function resolveKey($key)
{
$trimmed = \trim($key);
if(\strlen($trimmed) === 0)
Function offsetGet
has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring. Open
public function offsetGet(mixed $offset): mixed
{
if((\is_string($offset) || \is_numeric($offset)) && \key_exists($offset, $this->items))
{
return $this->items[$offset];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method offsetGet
has 35 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function offsetGet(mixed $offset): mixed
{
if((\is_string($offset) || \is_numeric($offset)) && \key_exists($offset, $this->items))
{
return $this->items[$offset];
Function parseParameters
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
private function parseParameters(string $parameters): Collection
{
$out = [];
$pos = 0;
$level = 0;
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function subtract
has a Cognitive Complexity of 11 (exceeds 5 allowed). Consider refactoring. Open
public function subtract(DatePeriod ...$periods): DateRange
{
foreach($periods as $period)
{
foreach($this->periods->filter(fn($p) => $period->intersectsWith($p)) as $i => $p)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Method has
has 30 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function has($key, string ...$keys): bool
{
\array_unshift($keys, $key);
return $this->some(function($i, $row) use($keys){
Method parseParameters
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
private function parseParameters(string $parameters): Collection
{
$out = [];
$pos = 0;
$level = 0;
Method get
has 29 lines of code (exceeds 25 allowed). Consider refactoring. Open
public function get($key, string ...$keys): Resolvable
{
\array_unshift($keys, $key);
if(!$this->has(...$keys))
Function each
has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring. Open
public function each(callable $callback): CollectionInterface
{
$collection = [];
foreach($this->items as $key => $value)
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"