chris-kruining/utilities

View on GitHub
src/Collections/Table.php

Summary

Maintainability
C
1 day
Test Coverage

File Table.php has 285 lines of code (exceeds 250 allowed). Consider refactoring.
Open

<?php

namespace CPB\Utilities\Collections
{
    use Core\Utility\Exception\NotImplemented;
Severity: Minor
Found in src/Collections/Table.php - About 2 hrs to fix

    Method join has 66 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

            public function join(
                iterable $iterable,
                string $localKey,
                string $foreignKey,
                JoinStrategy $strategy = null
    Severity: Major
    Found in src/Collections/Table.php - About 2 hrs to fix

      Method has has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

              public function has($key, string ...$keys): bool
              {
                  \array_unshift($keys, $key);
                  
                  return $this->some(function($i, $row) use($keys){
      Severity: Minor
      Found in src/Collections/Table.php - About 1 hr to fix

        Method get has 29 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

                public function get($key, string ...$keys): Resolvable
                {
                    \array_unshift($keys, $key);
                    
                    if(!$this->has(...$keys))
        Severity: Minor
        Found in src/Collections/Table.php - About 1 hr to fix

          Function join has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
          Open

                  public function join(
                      iterable $iterable,
                      string $localKey,
                      string $foreignKey,
                      JoinStrategy $strategy = null
          Severity: Minor
          Found in src/Collections/Table.php - About 1 hr to fix

          Cognitive Complexity

          Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

          A method's cognitive complexity is based on a few simple rules:

          • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
          • Code is considered more complex for each "break in the linear flow of the code"
          • Code is considered more complex when "flow breaking structures are nested"

          Further reading

          Avoid too many return statements within this method.
          Open

                                  return array_merge(
                                      $this->items[$k],
                                      $iterable[$v]
                                  );
          Severity: Major
          Found in src/Collections/Table.php - About 30 mins to fix

            Avoid too many return statements within this method.
            Open

                                $result = array_merge($result, array_filter($iterable, function($i) use($usedIndexes){ return !in_array($i, $usedIndexes); }, ARRAY_FILTER_USE_KEY));
            Severity: Major
            Found in src/Collections/Table.php - About 30 mins to fix

              Avoid too many return statements within this method.
              Open

                          return static::from($result);
              Severity: Major
              Found in src/Collections/Table.php - About 30 mins to fix

                There are no issues that match your filters.

                Category
                Status