Sign upLogin

chrismou/php-echonest-wrapper

View on GitHub
Star
src/Echonest.php

Summary

Maintainability
A
2 hrs
Test Coverage

Method query has 30 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    public function query(
        $httpMethod,
        $resource,
        $action,
        array $params = [],
Severity: Minor
Found in src/Echonest.php - About 1 hr to fix

    Method query has 7 arguments (exceeds 4 allowed). Consider refactoring.
    Open

            $httpMethod,
        $resource,
        $action,
        array $params = [],
        array $guzzleOptions = [],
    Severity: Major
    Found in src/Echonest.php - About 50 mins to fix

      Function query has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
      Open

          public function query(
        $httpMethod,
        $resource,
        $action,
        array $params = [],
      Severity: Minor
      Found in src/Echonest.php - About 45 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      The method query has a boolean flag argument $autoRateLimit, which is a certain sign of a Single Responsibility Principle violation.
      Open

              $autoRateLimit = true,
      Severity: Minor
      Found in src/Echonest.php by phpmd

      BooleanArgumentFlag

      Since: 1.4.0

      A boolean flag argument is a reliable indicator for a violation of the Single Responsibility Principle (SRP). You can fix this problem by extracting the logic in the boolean flag into its own class or method.

      Example

      class Foo {
    public function bar($flag = true) {
    }
}

      Source https://phpmd.org/rules/cleancode.html#booleanargumentflag

      Missing class import via use statement (line '142', column '23').
      Open

                  throw new \Chrismou\Echonest\Exception\TooManyAttemptsException($message);
      Severity: Minor
      Found in src/Echonest.php by phpmd

      MissingImport

      Since: 2.7.0

      Importing all external classes in a file through use statements makes them clearly visible.

      Example

      function make() {
    return new \stdClass();
}

      Source http://phpmd.org/rules/cleancode.html#MissingImport

      The method query uses an else expression. Else clauses are basically not necessary and you can simplify the code by not using them.
      Open

              } else {
            $urlParams = $params;
        }
      Severity: Minor
      Found in src/Echonest.php by phpmd

      ElseExpression

      Since: 1.4.0

      An if expression with an else branch is basically not necessary. You can rewrite the conditions in a way that the else clause is not necessary and the code becomes simpler to read. To achieve this, use early return statements, though you may need to split the code it several smaller methods. For very simple assignments you could also use the ternary operations.

      Example

      class Foo
{
    public function bar($flag)
    {
        if ($flag) {
            // one branch
        } else {
            // another branch
        }
    }
}

      Source https://phpmd.org/rules/cleancode.html#elseexpression

      There are no issues that match your filters.

      Category
      Status