cleverness/widget-css-classes

View on GitHub

Showing 9 of 9 total issues

In footer ($in_footer) is not set explicitly wp_enqueue_script; It is recommended to load scripts in the footer. Please set this value to true to load it in the footer, or explicitly false if it should be loaded in the header.
Open

            wp_enqueue_script( 'widget-css-classes_js', WCSSC_PLUGIN_URL . '/js/widget-css-classes.js', array( 'jquery' ), WCSSC_PLUGIN_VERSION );

Missing class import via use statement (line '29', column '7').
Open

        new WCSSC_Settings();

MissingImport

Since: 2.7.0

Importing all external classes in a file through use statements makes them clearly visible.

Example

function make() {
    return new \stdClass();
}

Source http://phpmd.org/rules/cleancode.html#MissingImport

Avoid assigning values to variables in if clauses and the like (line '651', column '14').
Open

    public static function append_to_attribute( $str, $attr, $content_extra, $unique = false ) {

        // Check if attribute has single or double quotes.
        // @codingStandardsIgnoreLine
        if ( $start = stripos( $str, $attr . '="' ) ) {
Severity: Minor
Found in includes/widget-css-classes.class.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

Avoid assigning values to variables in if clauses and the like (line '646', column '8').
Open

    public static function append_to_attribute( $str, $attr, $content_extra, $unique = false ) {

        // Check if attribute has single or double quotes.
        // @codingStandardsIgnoreLine
        if ( $start = stripos( $str, $attr . '="' ) ) {
Severity: Minor
Found in includes/widget-css-classes.class.php by phpmd

IfStatementAssignment

Since: 2.7.0

Assignments in if clauses and the like are considered a code smell. Assignments in PHP return the right operand as their result. In many cases, this is an expected behavior, but can lead to many difficult to spot bugs, especially when the right operand could result in zero, null or an empty string and the like.

Example

class Foo
{
    public function bar($flag)
    {
        if ($foo = 'bar') { // possible typo
            // ...
        }
        if ($baz = 0) { // always false
            // ...
        }
    }
}

Source http://phpmd.org/rules/cleancode.html#ifstatementassignment

The method extend_widget_form() has a Cyclomatic Complexity of 11. The configured cyclomatic complexity threshold is 10.
Open

    public static function extend_widget_form( $widget, $return, $instance ) {
        self::init();
        $instance = wp_parse_args(
            $instance,
            array(
Severity: Minor
Found in includes/widget-css-classes.class.php by phpmd

CyclomaticComplexity

Since: 0.1

Complexity is determined by the number of decision points in a method plus one for the method entry. The decision points are 'if', 'while', 'for', and 'case labels'. Generally, 1-4 is low complexity, 5-7 indicates moderate complexity, 8-10 is high complexity, and 11+ is very high complexity.

Example

// Cyclomatic Complexity = 11
class Foo {
1   public function example() {
2       if ($a == $b) {
3           if ($a1 == $b1) {
                fiddle();
4           } elseif ($a2 == $b2) {
                fiddle();
            } else {
                fiddle();
            }
5       } elseif ($c == $d) {
6           while ($c == $d) {
                fiddle();
            }
7        } elseif ($e == $f) {
8           for ($n = 0; $n < $h; $n++) {
                fiddle();
            }
        } else {
            switch ($z) {
9               case 1:
                    fiddle();
                    break;
10              case 2:
                    fiddle();
                    break;
11              case 3:
                    fiddle();
                    break;
                default:
                    fiddle();
                    break;
            }
        }
    }
}

Source https://phpmd.org/rules/codesize.html#cyclomaticcomplexity

End of line character is invalid; expected "\n" but found "\r\n"
Open

<?php

End of line character is invalid; expected "\n" but found "\r\n"
Open

<?php

End of line character is invalid; expected "\n" but found "\r\n"
Open

<?php

End of line character is invalid; expected "\n" but found "\r\n"
Open

<?php
Severity
Category
Status
Source
Language