cloudfoundry/cloud_controller_ng

View on GitHub

Showing 555 of 2,637 total issues

File domains_spec.rb has 1960 lines of code (exceeds 250 allowed). Consider refactoring.
Open

require 'spec_helper'
require 'request_spec_shared_examples'

RSpec.describe 'Domains Request' do
  let(:user) { VCAP::CloudController::User.make }
Severity: Major
Found in spec/request/domains_spec.rb - About 5 days to fix

    File app_manifest_message_spec.rb has 1774 lines of code (exceeds 250 allowed). Consider refactoring.
    Open

    require 'spec_helper'
    require 'messages/app_manifest_message'
    
    module VCAP::CloudController
      RSpec.describe AppManifestMessage do
    Severity: Major
    Found in spec/unit/messages/app_manifest_message_spec.rb - About 4 days to fix

      File service_broker_spec.rb has 1596 lines of code (exceeds 250 allowed). Consider refactoring.
      Open

      require 'spec_helper'
      
      RSpec.describe 'Service Broker' do
        include VCAP::CloudController::BrokerApiHelper
      
      
      Severity: Major
      Found in spec/acceptance/service_broker_spec.rb - About 4 days to fix

        File roles_spec.rb has 1495 lines of code (exceeds 250 allowed). Consider refactoring.
        Open

        require 'spec_helper'
        require 'request_spec_shared_examples'
        
        RSpec.describe 'Roles Request' do
          let(:user) { VCAP::CloudController::User.make(guid: 'user_guid') }
        Severity: Major
        Found in spec/request/roles_spec.rb - About 3 days to fix

          File security_groups_spec.rb has 1306 lines of code (exceeds 250 allowed). Consider refactoring.
          Open

          require 'spec_helper'
          require 'request_spec_shared_examples'
          
          RSpec.describe 'Security_Groups Request' do
            let(:space) { VCAP::CloudController::Space.make(guid: 'space-guid') }
          Severity: Major
          Found in spec/request/security_groups_spec.rb - About 3 days to fix

            File permissions_spec.rb has 1006 lines of code (exceeds 250 allowed). Consider refactoring.
            Open

            require 'spec_helper'
            
            module VCAP::CloudController
              RSpec.describe Permissions do
                let(:user) { User.make }
            Severity: Major
            Found in spec/unit/lib/cloud_controller/permissions_spec.rb - About 2 days to fix

              File users_controller_spec.rb has 997 lines of code (exceeds 250 allowed). Consider refactoring.
              Open

              require 'spec_helper'
              
              ## NOTICE: Prefer request specs over controller specs as per ADR #0003 ##
              
              module VCAP::CloudController
              Severity: Major
              Found in spec/unit/controllers/runtime/users_controller_spec.rb - About 2 days to fix

                File users_spec.rb has 901 lines of code (exceeds 250 allowed). Consider refactoring.
                Open

                require 'spec_helper'
                require 'request_spec_shared_examples'
                
                RSpec.describe 'Users Request' do
                  let(:actee) { VCAP::CloudController::User.make(guid: actee_guid) }
                Severity: Major
                Found in spec/request/users_spec.rb - About 2 days to fix

                  File space_quotas_spec.rb has 897 lines of code (exceeds 250 allowed). Consider refactoring.
                  Open

                  require 'spec_helper'
                  require 'request_spec_shared_examples'
                  
                  module VCAP::CloudController
                    RSpec.describe 'space_quotas' do
                  Severity: Major
                  Found in spec/request/space_quotas_spec.rb - About 2 days to fix

                    File service_manager_spec.rb has 885 lines of code (exceeds 250 allowed). Consider refactoring.
                    Open

                    require 'spec_helper'
                    require 'models/runtime/event'
                    require 'repositories/service_event_repository'
                    require 'cloud_controller/security_context'
                    
                    
                    Severity: Major
                    Found in spec/unit/lib/services/service_brokers/service_manager_spec.rb - About 2 days to fix

                      File _lunr.js has 884 lines of code (exceeds 250 allowed). Consider refactoring.
                      Open

                      /**
                       * lunr - http://lunrjs.com - A bit like Solr, but much smaller and not as bright - 0.5.7
                       * Copyright (C) 2014 Oliver Nightingale
                       * MIT Licensed
                       * @license
                      Severity: Major
                      Found in docs/v3/source/javascripts/lib/_lunr.js - About 2 days to fix

                        File organization_quotas_create_message_spec.rb has 831 lines of code (exceeds 250 allowed). Consider refactoring.
                        Open

                        require 'spec_helper'
                        require 'messages/organization_quotas_create_message'
                        
                        module VCAP::CloudController
                          RSpec.describe OrganizationQuotasCreateMessage do
                        Severity: Major
                        Found in spec/unit/messages/organization_quotas_create_message_spec.rb - About 1 day to fix

                          File security_group_spec.rb has 801 lines of code (exceeds 250 allowed). Consider refactoring.
                          Open

                          require 'spec_helper'
                          
                          module VCAP::CloudController
                            RSpec.describe SecurityGroup, type: :model do
                              def build_transport_rule(attrs={})
                          Severity: Major
                          Found in spec/unit/models/runtime/security_group_spec.rb - About 1 day to fix

                            File uaa_client_spec.rb has 771 lines of code (exceeds 250 allowed). Consider refactoring.
                            Open

                            require 'spec_helper'
                            
                            module VCAP::CloudController
                              RSpec.describe UaaClient do
                                let(:url) { 'http://uaa.example.com' }
                            Severity: Major
                            Found in spec/unit/lib/uaa/uaa_client_spec.rb - About 1 day to fix

                              File sidecars_spec.rb has 696 lines of code (exceeds 250 allowed). Consider refactoring.
                              Open

                              require 'spec_helper'
                              require 'request_spec_shared_examples'
                              
                              RSpec.describe 'Sidecars' do
                                let(:app_model) { VCAP::CloudController::AppModel.make }
                              Severity: Major
                              Found in spec/request/sidecars_spec.rb - About 1 day to fix

                                File model_controller_spec.rb has 687 lines of code (exceeds 250 allowed). Consider refactoring.
                                Open

                                require 'spec_helper'
                                require 'stringio'
                                
                                module VCAP::CloudController
                                  RSpec.describe RestController::ModelController do
                                Severity: Major
                                Found in spec/unit/controllers/base/model_controller_spec.rb - About 1 day to fix

                                  File space_manifests_controller_spec.rb has 664 lines of code (exceeds 250 allowed). Consider refactoring.
                                  Open

                                  require 'rails_helper'
                                  require 'permissions_spec_helper'
                                  
                                  ## NOTICE: Prefer request specs over controller specs as per ADR #0003 ##
                                  
                                  
                                  Severity: Major
                                  Found in spec/unit/controllers/v3/space_manifests_controller_spec.rb - About 1 day to fix

                                    Class ProcessModel has 78 methods (exceeds 20 allowed). Consider refactoring.
                                    Open

                                      class ProcessModel < Sequel::Model(:processes)
                                        include Serializer
                                    
                                        plugin :serialization
                                        plugin :after_initialize
                                    Severity: Major
                                    Found in app/models/runtime/process_model.rb - About 1 day to fix

                                      File revisions_spec.rb has 618 lines of code (exceeds 250 allowed). Consider refactoring.
                                      Open

                                      require 'spec_helper'
                                      require 'request_spec_shared_examples'
                                      
                                      RSpec.describe 'Revisions' do
                                        let(:user) { VCAP::CloudController::User.make }
                                      Severity: Major
                                      Found in spec/request/revisions_spec.rb - About 1 day to fix

                                        File organization_quotas_spec.rb has 613 lines of code (exceeds 250 allowed). Consider refactoring.
                                        Open

                                        require 'spec_helper'
                                        require 'request_spec_shared_examples'
                                        
                                        module VCAP::CloudController
                                          RSpec.describe 'organization_quotas' do
                                        Severity: Major
                                        Found in spec/request/organization_quotas_spec.rb - About 1 day to fix
                                          Severity
                                          Category
                                          Status
                                          Source
                                          Language