Sign upLogin

cloudfoundry/cloudfoundry-buildpack-java

View on GitHub
Star

Showing 4 of 4 total issues

Method fetch_from_blobstore has 33 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    def fetch_from_blobstore(filename)
      config = YAML.load_file File.expand_path(BLOBSTORE_CONFIG)
      return if config["blobs"][filename].nil?
      oid = config["blobs"][filename]["oid"]
      sig = config["blobs"][filename]["sig"]
Severity: Minor
Found in lib/language_pack/package_fetcher.rb - About 1 hr to fix

    Method fetch_from_blobstore has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

        def fetch_from_blobstore(filename)
      config = YAML.load_file File.expand_path(BLOBSTORE_CONFIG)
      return if config["blobs"][filename].nil?
      oid = config["blobs"][filename]["oid"]
      sig = config["blobs"][filename]["sig"]
    Severity: Minor
    Found in lib/language_pack/package_fetcher.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method initialize has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def initialize(web_xml, default_app_context_location, context_params, servlet_params,  default_servlet_context_locations={})
    Severity: Minor
    Found in lib/language_pack/web_xml_config.rb - About 35 mins to fix

      Method properties has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def properties(props_file)
      properties = {}
      IO.foreach(props_file) do |line|
        if line =~ /([^=]*)=(.*)\/\/(.*)/ || line =~ /([^=]*)=(.*)/
          case $2
      Severity: Minor
      Found in lib/language_pack/java.rb - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language