Showing 1,155 of 1,370 total issues
Method HelmRelease.parseManifest
has a Cognitive Complexity of 31 (exceeds 8 allowed). Consider refactoring. Open
func (r *HelmRelease) parseManifest() {
r.ManifestErrors = false
reader := bytes.NewReader([]byte(r.Manifest))
buffer := bufio.NewReader(reader)
var bufr strings.Builder
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
Function get
has a Cognitive Complexity of 31 (exceeds 8 allowed). Consider refactoring. Open
get(summary: any, appInstances: AppStat[]): ApplicationStateData {
const appState: string = summary ? summary.state : 'UNKNOWN';
const pkgState = this.getPackageState(appState, summary);
const wildcard = this.stateMetadata['?'];
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File quota-definitions.actions.ts
has 336 lines of code (exceeds 250 allowed). Consider refactoring. Open
import { HttpParams, HttpRequest } from '@angular/common/http';
import { PaginatedAction } from '../../../store/src/types/pagination.types';
import { ICFAction } from '../../../store/src/types/request.types';
import { IQuotaDefinition } from '../cf-api.types';
Similar blocks of code found in 2 locations. Consider refactoring. Open
export class CFEndpointsListConfigService implements IListConfig<EndpointModel> {
columns: ITableColumn<EndpointModel>[];
isLocal = true;
dataSource: CFEndpointsDataSource;
viewType = ListViewTypes.CARD_ONLY;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 271.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Similar blocks of code found in 2 locations. Consider refactoring. Open
export class KubernetesEndpointsListConfigService implements IListConfig<EndpointModel> {
columns: ITableColumn<EndpointModel>[];
isLocal = true;
dataSource: BaseEndpointsDataSource;
viewType = ListViewTypes.CARD_ONLY;
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 271.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
CfTopLevelPage
has 32 functions (exceeds 20 allowed). Consider refactoring. Open
export class CfTopLevelPage extends CFPage {
private readonly until = protractor.ExpectedConditions;
constructor() {
Function ngOnInit
has 100 lines of code (exceeds 25 allowed). Consider refactoring. Open
ngOnInit() {
this.cardTwoFetching$ = this.applicationService.application$.pipe(
combineLatest(
this.applicationService.appSummary$
),
Function constructor
has 100 lines of code (exceeds 25 allowed). Consider refactoring. Open
constructor(
public activatedRoute: ActivatedRoute,
public kubeEndpointService: KubernetesEndpointService
) {
this.podName = activatedRoute.snapshot.params.podName;
File cf-org-space-service.service.ts
has 332 lines of code (exceeds 250 allowed). Consider refactoring. Open
import { Injectable, OnDestroy } from '@angular/core';
import { Store } from '@ngrx/store';
import { BehaviorSubject, combineLatest, Observable, of, Subscription } from 'rxjs';
import {
distinctUntilChanged,
Function getFolderSource
has a Cognitive Complexity of 30 (exceeds 8 allowed). Consider refactoring. Open
func getFolderSource(clientWebSocket *websocket.Conn, tempDir string, msg SocketMessage) (StratosProject, string, error) {
// The msg data is JSON for the Folder info
info := FolderSourceInfo{
WaitAfterUpload: false,
}
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File autoscaler-transform-policy.spec.ts
has 328 lines of code (exceeds 250 allowed). Consider refactoring. Open
import { isEqual } from './autoscaler-util';
import {
autoscalerTransformArrayToMap,
autoscalerTransformMapToArray,
} from './autoscaler-transform-policy';
File services-helper-e2e.ts
has 327 lines of code (exceeds 250 allowed). Consider refactoring. Open
import { browser, promise, protractor } from 'protractor';
import { IService, IServiceInstance, IServicePlan } from '../../frontend/packages/cloud-foundry/src/cf-api-svc.types';
import { CFResponse, createEmptyCfResponse } from '../../frontend/packages/cloud-foundry/src/store/types/cf-api.types';
import { APIResource } from '../../frontend/packages/store/src/types/api.types';
File shared.module.ts
has 327 lines of code (exceeds 250 allowed). Consider refactoring. Open
import { CdkTableModule } from '@angular/cdk/table';
import { CommonModule } from '@angular/common';
import { NgModule } from '@angular/core';
import { FormsModule, ReactiveFormsModule } from '@angular/forms';
import { RouterModule } from '@angular/router';
Method CFAppPush.deploy
has 121 lines of code (exceeds 50 allowed). Consider refactoring. Open
func (cfAppPush *CFAppPush) deploy(echoContext echo.Context) error {
cnsiGUID := echoContext.Param("cnsiGuid")
orgGUID := echoContext.Param("orgGuid")
spaceGUID := echoContext.Param("spaceGuid")
Function ngOnInit
has 96 lines of code (exceeds 25 allowed). Consider refactoring. Open
public ngOnInit() {
const contentElement = this.content.nativeElement;
const containerElement = this.container.nativeElement;
this.stopped$ = new BehaviorSubject<boolean>(false);
File cf-user-list-config.service.ts
has 324 lines of code (exceeds 250 allowed). Consider refactoring. Open
import { Router } from '@angular/router';
import { Store } from '@ngrx/store';
import { BehaviorSubject, combineLatest, Observable, of as observableOf } from 'rxjs';
import { filter, first, map, switchMap, tap } from 'rxjs/operators';
Method CFHosting.Init
has a Cognitive Complexity of 29 (exceeds 8 allowed). Consider refactoring. Open
func (ch *CFHosting) Init() error {
// Determine if we are running CF by presence of env var "VCAP_APPLICATION" and configure appropriately
if ch.portalProxy.Env().IsSet(VCapApplication) {
log.Info("Detected that Console is deployed as a Cloud Foundry Application")
- Read upRead up
Cognitive Complexity
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
Further reading
File application-wall-e2e.spec.ts
has 320 lines of code (exceeds 250 allowed). Consider refactoring. Open
import { browser, promise } from 'protractor';
import { IOrganization, ISpace } from '../../frontend/packages/cloud-foundry/src/cf-api.types';
import { APIResource } from '../../frontend/packages/store/src/types/api.types';
import { ApplicationE2eHelper } from '../application/application-e2e-helpers';
File specify-user-provided-details.component.ts
has 319 lines of code (exceeds 250 allowed). Consider refactoring. Open
import { COMMA, ENTER, SPACE } from '@angular/cdk/keycodes';
import { HttpHeaders, HttpParams, HttpRequest } from '@angular/common/http';
import { Component, Input, OnDestroy } from '@angular/core';
import { FormControl, FormGroup, Validators } from '@angular/forms';
import { MatChipInputEvent } from '@angular/material/chips';
Identical blocks of code found in 2 locations. Consider refactoring. Open
func updateCFFIle(updates map[string]string) error {
usr, err := user.Current()
if err != nil {
return err
}
- Read upRead up
Duplicated Code
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
Tuning
This issue has a mass of 289.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
See codeclimate-duplication
's documentation for more information about tuning the mass threshold in your .codeclimate.yml
.
Refactorings
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
Further Reading
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76