cloudfoundry/stratos

View on GitHub
src/frontend/packages/cf-autoscaler/src/store/autoscaler.effects.ts

Summary

Maintainability
C
1 day
Test Coverage

File autoscaler.effects.ts has 528 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { HttpClient, HttpErrorResponse } from '@angular/common/http';
import { Injectable } from '@angular/core';
import { Actions, Effect, ofType } from '@ngrx/effects';
import { Action, Store } from '@ngrx/store';
import { Observable } from 'rxjs';
Severity: Major
Found in src/frontend/packages/cf-autoscaler/src/store/autoscaler.effects.ts - About 1 day to fix

    AutoscalerEffects has 22 functions (exceeds 20 allowed). Consider refactoring.
    Wontfix

    @Injectable()
    export class AutoscalerEffects {
      constructor(
        private http: HttpClient,
        private actions$: Actions,
    Severity: Minor
    Found in src/frontend/packages/cf-autoscaler/src/store/autoscaler.effects.ts - About 2 hrs to fix

      Function fetchPolicy has 51 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private fetchPolicy(
          getPolicyAction: GetAppAutoscalerPolicyAction,
          getPolicyTriggerAction?: GetAppAutoscalerPolicyTriggerAction): Observable<Action> {
          const actionType = 'fetch';
          this.store.dispatch(new StartRequestAction(getPolicyAction, actionType));
      Severity: Major
      Found in src/frontend/packages/cf-autoscaler/src/store/autoscaler.effects.ts - About 2 hrs to fix

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

          @Effect()
          deleteAppAutoscalerCredential$ = this.actions$.pipe(
            ofType<DeleteAppAutoscalerCredentialAction>(DELETE_APP_AUTOSCALER_CREDENTIAL),
            mergeMap(action => {
              const actionType = 'delete';
        src/frontend/packages/cf-autoscaler/src/store/autoscaler.effects.ts on lines 184..208

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 253.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

          @Effect()
          detachAppAutoscalerPolicy$ = this.actions$.pipe(
            ofType<DetachAppAutoscalerPolicyAction>(DETACH_APP_AUTOSCALER_POLICY),
            mergeMap(action => {
              const actionType = 'delete';
        src/frontend/packages/cf-autoscaler/src/store/autoscaler.effects.ts on lines 245..269

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 253.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status