Sign upLogin

cloudfoundry/stratos

View on GitHub
Star
src/frontend/packages/kubernetes/src/kubernetes/workloads/release/helm-release-tab-base/helm-release-socket-service.ts

Summary

Maintainability
C
1 day
Test Coverage

Function start has 82 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  public start() {
    if (this.isStarted()) {
      return;
    }
Severity: Major
Found in src/frontend/packages/kubernetes/src/kubernetes/workloads/release/helm-release-tab-base/helm-release-socket-service.ts - About 3 hrs to fix

    Function start has a Cognitive Complexity of 19 (exceeds 8 allowed). Consider refactoring.
    Open

      public start() {
    if (this.isStarted()) {
      return;
    }
    Severity: Minor
    Found in src/frontend/packages/kubernetes/src/kubernetes/workloads/release/helm-release-tab-base/helm-release-socket-service.ts - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function sub has 52 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

        this.sub = messages.subscribe(jsonString => {
      const messageObj = JSON.parse(jsonString);
      if (messageObj) {
        if (messageObj.kind === 'ReleasePrefix') {
          prefix = messageObj.data;
    Severity: Major
    Found in src/frontend/packages/kubernetes/src/kubernetes/workloads/release/helm-release-tab-base/helm-release-socket-service.ts - About 2 hrs to fix

      Avoid deeply nested control flow statements.
      Open

                      if (!resources[entityType]) {
                  resources[entityType] = [];
                }
      Severity: Major
      Found in src/frontend/packages/kubernetes/src/kubernetes/workloads/release/helm-release-tab-base/helm-release-socket-service.ts - About 45 mins to fix

        TODO found
        Open

            // TODO: Ideally this should come from some kubeEntityCatalog.allKubeEntities `def.apiName === resource.kind && def.apiWorkspaced`
        Severity: Minor
        Found in src/frontend/packages/kubernetes/src/kubernetes/workloads/release/helm-release-tab-base/helm-release-socket-service.ts by fixme

        There are no issues that match your filters.

        Category
        Status