cloudfoundry/stratos

View on GitHub
src/test-e2e/applications/application-wall-e2e.spec.ts

Summary

Maintainability
D
1 day
Test Coverage

File application-wall-e2e.spec.ts has 320 lines of code (exceeds 250 allowed). Consider refactoring.
Open

import { browser, promise } from 'protractor';

import { IOrganization, ISpace } from '../../frontend/packages/cloud-foundry/src/cf-api.types';
import { APIResource } from '../../frontend/packages/store/src/types/api.types';
import { ApplicationE2eHelper } from '../application/application-e2e-helpers';
Severity: Minor
Found in src/test-e2e/applications/application-wall-e2e.spec.ts - About 3 hrs to fix

    Function setup has 31 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      function setup(orgName: string, appNames: string[], orderImportant: boolean) {
        defaultCf = e2e.secrets.getDefaultCFEndpoint();
        endpointGuid = e2e.helper.getEndpointGuid(e2e.info, defaultCf.name);
    
        return browser.wait(
    Severity: Minor
    Found in src/test-e2e/applications/application-wall-e2e.spec.ts - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          function testSortBy(sortFieldName: string) {
            const sortFieldForm = appList.header.getSortFieldForm();
            sortFieldForm.fill({ 'sort-field': sortFieldName });
      
            let expectedTitleOrder: string[];
      Severity: Major
      Found in src/test-e2e/applications/application-wall-e2e.spec.ts and 1 other location - About 3 hrs to fix
      src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts on lines 126..145

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 259.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

          it('text filter by non-existing', () => {
            // Clear and check initial cards
            appList.header.clearSearchText();
            expect(appList.header.getSearchText()).toBeFalsy();
            expect(appList.cards.getCardCount()).toBeGreaterThanOrEqual(appNames.length);
      Severity: Major
      Found in src/test-e2e/applications/application-wall-e2e.spec.ts and 1 other location - About 2 hrs to fix
      src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts on lines 180..198

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 231.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

            it('Last and First Page', () => {
              appList.pagination.getNavLastPage().getComponent().click();
      
              expect(appList.pagination.getNavFirstPage().getComponent().isEnabled()).toBeTruthy();
              expect(appList.pagination.getNavPreviousPage().getComponent().isEnabled()).toBeTruthy();
      Severity: Major
      Found in src/test-e2e/applications/application-wall-e2e.spec.ts and 4 other locations - About 1 hr to fix
      src/test-e2e/applications/application-wall-e2e.spec.ts on lines 310..319
      src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts on lines 241..250
      src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts on lines 252..261
      src/test-e2e/cloud-foundry/space-level/space-routes-e2e.spec.ts on lines 224..233

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 225.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 5 locations. Consider refactoring.
      Open

            it('Next and Previous Page', () => {
              appList.pagination.getNavNextPage().getComponent().click();
      
              expect(appList.pagination.getNavFirstPage().getComponent().isEnabled()).toBeTruthy();
              expect(appList.pagination.getNavPreviousPage().getComponent().isEnabled()).toBeTruthy();
      Severity: Major
      Found in src/test-e2e/applications/application-wall-e2e.spec.ts and 4 other locations - About 1 hr to fix
      src/test-e2e/applications/application-wall-e2e.spec.ts on lines 321..330
      src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts on lines 241..250
      src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts on lines 252..261
      src/test-e2e/cloud-foundry/space-level/space-routes-e2e.spec.ts on lines 224..233

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 225.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status