Sign upLogin

cloudfoundry/stratos

View on GitHub
Star
src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts

Summary

Maintainability
C
1 day
Test Coverage

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    function testSortBy(sortFieldName: string) {
      const sortFieldForm = spaceList.header.getSortFieldForm();
      sortFieldForm.fill({ 'sort-field': sortFieldName });

      let expectedTitleOrder: string[];
Severity: Major
Found in src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts and 1 other location - About 3 hrs to fix
src/test-e2e/applications/application-wall-e2e.spec.ts on lines 173..192

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 259.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 2 locations. Consider refactoring.
Open

    it('text filter by non-existing', () => {
      // Clear and check initial cards
      spaceList.header.clearSearchText();
      expect(spaceList.header.getSearchText()).toBeFalsy();
      expect(spaceList.cards.getCardCount()).toBeGreaterThanOrEqual(spaceNames.length);
Severity: Major
Found in src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts and 1 other location - About 2 hrs to fix
src/test-e2e/applications/application-wall-e2e.spec.ts on lines 242..260

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 231.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('Last and First Page', () => {
      spaceList.pagination.getNavLastPage().getComponent().click();

      expect(spaceList.pagination.getNavFirstPage().getComponent().isEnabled()).toBeTruthy();
      expect(spaceList.pagination.getNavPreviousPage().getComponent().isEnabled()).toBeTruthy();
Severity: Major
Found in src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts and 4 other locations - About 1 hr to fix
src/test-e2e/applications/application-wall-e2e.spec.ts on lines 310..319
src/test-e2e/applications/application-wall-e2e.spec.ts on lines 321..330
src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts on lines 241..250
src/test-e2e/cloud-foundry/space-level/space-routes-e2e.spec.ts on lines 224..233

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 225.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

Similar blocks of code found in 5 locations. Consider refactoring.
Open

    it('Next and Previous Page', () => {
      spaceList.pagination.getNavNextPage().getComponent().click();

      expect(spaceList.pagination.getNavFirstPage().getComponent().isEnabled()).toBeTruthy();
      expect(spaceList.pagination.getNavPreviousPage().getComponent().isEnabled()).toBeTruthy();
Severity: Major
Found in src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts and 4 other locations - About 1 hr to fix
src/test-e2e/applications/application-wall-e2e.spec.ts on lines 310..319
src/test-e2e/applications/application-wall-e2e.spec.ts on lines 321..330
src/test-e2e/cloud-foundry/org-level/org-spaces-e2e.spec.ts on lines 252..261
src/test-e2e/cloud-foundry/space-level/space-routes-e2e.spec.ts on lines 224..233

Duplicated Code

Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

Tuning

This issue has a mass of 225.

We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

Refactorings

Further Reading

There are no issues that match your filters.

Category
Status