coady/django-model-values

View on GitHub

Showing 3 of 3 total issues

File __init__.py has 546 lines of code (exceeds 250 allowed). Consider refactoring.
Open

from __future__ import annotations
import collections
import functools
import itertools
import math
Severity: Major
Found in model_values/__init__.py - About 1 day to fix

    Function bulk_change has 5 arguments (exceeds 4 allowed). Consider refactoring.
    Open

        def bulk_change(
    Severity: Minor
    Found in model_values/__init__.py - About 35 mins to fix

      Function upsert has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
      Open

          def upsert(self, defaults: Mapping = {}, **kwargs) -> int | models.Model:
              """Update or insert returning number of rows or created object.
      
              Faster and safer than ``update_or_create``.
              Supports combined expression updates by assuming the identity element on insert:  ``F(...) + 1``.
      Severity: Minor
      Found in model_values/__init__.py - About 25 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Severity
      Category
      Status
      Source
      Language