Sign upLogin

coast-team/netflux

View on GitHub
Star
src/service/channelBuilder/ChannelBuilder.ts

Summary

Maintainability
D
2 days
Test Coverage

File ChannelBuilder.ts has 322 lines of code (exceeds 250 allowed). Consider refactoring.
Confirmed

import { merge, Observable, Subject } from 'rxjs'

import { Channel } from '../../Channel'
import { isWebRTCSupported, isWebSocketSupported, log } from '../../misc/util'
import { channelBuilder as proto } from '../../proto/index'
Severity: Minor
Found in src/service/channelBuilder/ChannelBuilder.ts - About 3 hrs to fix

    Function handleMessage has 91 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      private handleMessage(
    streamId: number,
    senderId: number,
    recipientId: number,
    msg: proto.Message
    Severity: Major
    Found in src/service/channelBuilder/ChannelBuilder.ts - About 3 hrs to fix

      Function handleMessage has a Cognitive Complexity of 25 (exceeds 5 allowed). Consider refactoring.
      Open

        private handleMessage(
    streamId: number,
    senderId: number,
    recipientId: number,
    msg: proto.Message
      Severity: Minor
      Found in src/service/channelBuilder/ChannelBuilder.ts - About 3 hrs to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Function proceedNegotiation has 30 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        private async proceedNegotiation(
    streamId: number,
    initiator: proto.Info,
    passive: proto.Info,
    amIInitiator: boolean
      Severity: Minor
      Found in src/service/channelBuilder/ChannelBuilder.ts - About 1 hr to fix

        Function proceedNegotiation has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
        Open

          private async proceedNegotiation(
    streamId: number,
    initiator: proto.Info,
    passive: proto.Info,
    amIInitiator: boolean
        Severity: Minor
        Found in src/service/channelBuilder/ChannelBuilder.ts - About 55 mins to fix

        Cognitive Complexity

        Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

        A method's cognitive complexity is based on a few simple rules:

        • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
        • Code is considered more complex for each "break in the linear flow of the code"
        • Code is considered more complex when "flow breaking structures are nested"

        Further reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

            try {
      const type = this.getType(streamId, amIInitiator)
      const wcId = type === Channel.WITH_MEMBER ? theOther.wcId : this.wc.myId
      await this.wc.webSocketBuilder.connect(
        theOther.wss,
        Severity: Major
        Found in src/service/channelBuilder/ChannelBuilder.ts and 1 other location - About 1 hr to fix
        src/service/channelBuilder/ChannelBuilder.ts on lines 299..316

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Wontfix

            try {
      const type = this.getType(streamId, amIInitiator)
      await this.dataChannelBuilder.connect(
        theOther.id,
        me.id,
        Severity: Major
        Found in src/service/channelBuilder/ChannelBuilder.ts and 1 other location - About 1 hr to fix
        src/service/channelBuilder/ChannelBuilder.ts on lines 270..290

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 69.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

            if (me.wss && !theOther.wsTried) {
      log.channelBuilder(`Prompt the other to connect over WebSocket`)
      this.allStreams.sendOver(
        streamId,
        { negotiation: { initiator, passive } },
        Severity: Major
        Found in src/service/channelBuilder/ChannelBuilder.ts and 1 other location - About 1 hr to fix
        src/service/channelBuilder/ChannelBuilder.ts on lines 248..257

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

              if (!theOther.dcTried) {
        log.channelBuilder(`Prompt the other to connect over RTCDataChannel`)
        this.allStreams.sendOver(
          streamId,
          { negotiation: { initiator, passive } },
        Severity: Major
        Found in src/service/channelBuilder/ChannelBuilder.ts and 1 other location - About 1 hr to fix
        src/service/channelBuilder/ChannelBuilder.ts on lines 230..239

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 64.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status