Sign upLogin

codeclimate/codeclimate-eslint

View on GitHub
Star

Showing 15 of 15 total issues

Function run has 183 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function run(console, runOptions) {
  const STDOUT = console.log;
  console.log = console.error;

  var configPath = runOptions.configPath || "/config.json";
Severity: Major
Found in lib/eslint.js - About 7 hrs to fix

    Function run has a Cognitive Complexity of 28 (exceeds 5 allowed). Consider refactoring.
    Open

    function run(console, runOptions) {
  const STDOUT = console.log;
  console.log = console.error;

  var configPath = runOptions.configPath || "/config.json";
    Severity: Minor
    Found in lib/eslint.js - About 4 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function upgradeEcmaFeatures has a Cognitive Complexity of 19 (exceeds 5 allowed). Consider refactoring.
    Open

    function upgradeEcmaFeatures(config) {
  let report = [];
  if (Reflect.has(config, "ecmaFeatures")) {
    let parserOptions = {};
    if (!Reflect.has(config, "parserOptions")) {
    Severity: Minor
    Found in lib/config_upgrader.js - About 2 hrs to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function 'upgradeEcmaFeatures' has a complexity of 10.
    Open

    function upgradeEcmaFeatures(config) {
    Severity: Minor
    Found in lib/config_upgrader.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function 'upgradeRules' has a complexity of 7.
    Open

    function upgradeRules(rules) {
    Severity: Minor
    Found in lib/config_upgrader.js by eslint

    Limit Cyclomatic Complexity (complexity)

    Cyclomatic complexity measures the number of linearly independent paths through a program's source code. This rule allows setting a cyclomatic complexity threshold.

    function a(x) {
    if (true) {
        return x; // 1st path
    } else if (false) {
        return x+1; // 2nd path
    } else {
        return 4; // 3rd path
    }
}

    Rule Details

    This rule is aimed at reducing code complexity by capping the amount of cyclomatic complexity allowed in a program. As such, it will warn when the cyclomatic complexity crosses the configured threshold (default is 20).

    Examples of incorrect code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else if (false) {
        return x+1;
    } else {
        return 4; // 3rd path
    }
}

    Examples of correct code for a maximum of 2:

    /*eslint complexity: ["error", 2]*/

function a(x) {
    if (true) {
        return x;
    } else {
        return 4;
    }
}

    Options

    Optionally, you may specify a max object property:

    "complexity": ["error", 2]

    is equivalent to

    "complexity": ["error", { "max": 2 }]

    Deprecated: the object property maximum is deprecated. Please use the property max instead.

    When Not To Use It

    If you can't determine an appropriate complexity limit for your code, then it's best to disable this rule.

    Further Reading

    Related Rules

    • [max-depth](max-depth.md)
    • [max-len](max-len.md)
    • [max-nested-callbacks](max-nested-callbacks.md)
    • [max-params](max-params.md)
    • [max-statements](max-statements.md) Source: http://eslint.org/docs/rules/

    Function upgradeRules has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

    function upgradeRules(rules) {
  let report = [];
  for (const oldName in removedRules) {
    if (Reflect.has(rules, oldName)) {
      let config = rules[oldName];
    Severity: Minor
    Found in lib/config_upgrader.js - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Function patch has 35 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

    module.exports = function patch() {
  const skippedModules = [];
  function warnModuleNotSupported(name) {
    if(!skippedModules.includes(name)) {
      skippedModules.push(name);
    Severity: Minor
    Found in lib/eslint-patch.js - About 1 hr to fix

      Function buildIssueJson has 34 lines of code (exceeds 25 allowed). Consider refactoring.
      Open

        function buildIssueJson(message, path) {
    // ESLint doesn't emit a ruleId in the
    // case of a fatal error (such as an invalid
    // token)
    var checkName = message.ruleId;
      Severity: Minor
      Found in lib/eslint.js - About 1 hr to fix

        Function upgradeEcmaFeatures has 33 lines of code (exceeds 25 allowed). Consider refactoring.
        Open

        function upgradeEcmaFeatures(config) {
  let report = [];
  if (Reflect.has(config, "ecmaFeatures")) {
    let parserOptions = {};
    if (!Reflect.has(config, "parserOptions")) {
        Severity: Minor
        Found in lib/config_upgrader.js - About 1 hr to fix

          Function analyzeFiles has 32 lines of code (exceeds 25 allowed). Consider refactoring.
          Open

            function analyzeFiles() {
    var batchNum = 0
      , batchSize = 10
      , batchFiles
      , batchReport;
          Severity: Minor
          Found in lib/eslint.js - About 1 hr to fix

            Function filterRules has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
            Open

            function filterRules(rules) {
  let report = [];

  for (const name of blocklistedRules) {
    if (Reflect.has(rules, name)) {
            Severity: Minor
            Found in lib/rule_blocklist.js - About 1 hr to fix

            Cognitive Complexity

            Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

            A method's cognitive complexity is based on a few simple rules:

            • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
            • Code is considered more complex for each "break in the linear flow of the code"
            • Code is considered more complex when "flow breaking structures are nested"

            Further reading

            Function upgradeInstructions has 27 lines of code (exceeds 25 allowed). Consider refactoring.
            Open

              static upgradeInstructions(configs, root) {
    const reports = configs.map(function(configFile) {
      let report = [];

      const upgrader = new ConfigUpgrader();
            Severity: Minor
            Found in lib/config_upgrader.js - About 1 hr to fix

              Function patch has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = function patch() {
  const skippedModules = [];
  function warnModuleNotSupported(name) {
    if(!skippedModules.includes(name)) {
      skippedModules.push(name);
              Severity: Minor
              Found in lib/eslint-patch.js - About 55 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function exports has a Cognitive Complexity of 8 (exceeds 5 allowed). Consider refactoring.
              Open

              module.exports = function(configPath) {
  if (configPath) {
    return fs.existsSync(configPath);
  } else {
    let cli = new CLIEngine();
              Severity: Minor
              Found in lib/validate_config.js - About 45 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Function remediationPoints has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
              Open

              var remediationPoints = function(checkName, message, eslintConfig) {
  if (categories(checkName)[0] === "Complexity") {
    // (@base_cost + (overage * @cost_per))*1_000_000
    // cost_per: 0.1,  base: 1
    var costPer = 70000
              Severity: Minor
              Found in lib/checks.js - About 35 mins to fix

              Cognitive Complexity

              Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

              A method's cognitive complexity is based on a few simple rules:

              • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
              • Code is considered more complex for each "break in the linear flow of the code"
              • Code is considered more complex when "flow breaking structures are nested"

              Further reading

              Severity
              Category
              Status
              Source
              Language