Sign upLogin

codenothing/CSSCompressor

View on GitHub
Star
lib/formats/Minimum.js

Summary

Maintainability
F
3 days
Test Coverage

Function render has 95 lines of code (exceeds 25 allowed). Consider refactoring.
Open

function render( css, branches, indent ) {
    if ( indent === undefined ) {
        indent = '';
    }
Severity: Major
Found in lib/formats/Minimum.js - About 3 hrs to fix

    Consider simplifying this complex logical expression.
    Open

                if ( branch.branches || branch.rules ) {
                css += indent + selector + " {" + ( branch.rules && branch.branches ? "\n\t" + indent : '' );

                // Add rules
                branch.rules.forEach(function( rule, i ) {
    Severity: Major
    Found in lib/formats/Minimum.js - About 40 mins to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  branch.rules.forEach(function( rule, i ) {
                if ( i > 0 ) {
                    css += " ";
                }
      Severity: Major
      Found in lib/formats/Minimum.js and 1 other location - About 1 day to fix
      lib/formats/Minimum.js on lines 100..127

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 227.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                      branch.rules.forEach(function( rule, i ) {
                    if ( i > 0 ) {
                        css += " ";
                    }
      Severity: Major
      Found in lib/formats/Minimum.js and 1 other location - About 1 day to fix
      lib/formats/Minimum.js on lines 45..72

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 227.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 2 locations. Consider refactoring.
      Open

                  branch.parts.forEach(function( part, i ) {
                if ( part === ',' ) {
                    sections.push( section = [] );
                    return;
                }
      Severity: Major
      Found in lib/formats/Minimum.js and 1 other location - About 3 hrs to fix
      lib/formats/Medium.js on lines 24..34

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 96.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Identical blocks of code found in 3 locations. Consider refactoring.
      Open

                  branch.parts.forEach(function( part, i ) {
                var prev = branch.parts[ i - 1 ];

                if ( selector.length && part != ',' ) {
                    selector += ' ';
      Severity: Major
      Found in lib/formats/Minimum.js and 2 other locations - About 2 hrs to fix
      lib/formats/Max.js on lines 81..89
      lib/formats/Medium.js on lines 84..92

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 76.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      There are no issues that match your filters.

      Category
      Status