Sign upLogin

codenothing/CSSCompressor

View on GitHub
Star
lib/rules/Border Radius Combinations.js

Summary

Maintainability
F
3 days
Test Coverage

Function callback has 145 lines of code (exceeds 25 allowed). Consider refactoring.
Open

    callback: function( branch, compressor ) {
        if ( ! branch.rules || ! branch.rules.length ) {
            return;
        }
Severity: Major
Found in lib/rules/Border Radius Combinations.js - About 5 hrs to fix

    Avoid deeply nested control flow statements.
    Open

                            if ( rule.parts.length == 2 ) {
                            separator = true;
                            sections[ 0 ][ 1 ] = rule.parts[ 0 ];
                            sections[ 1 ][ 1 ] = rule.parts[ 1 ];
                        }
    Severity: Major
    Found in lib/rules/Border Radius Combinations.js - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                          else if ( rule.property == graph.bottomright ) {
                        if ( rule.parts.length == 2 ) {
                            separator = true;
                            sections[ 0 ][ 2 ] = rule.parts[ 0 ];
                            sections[ 1 ][ 2 ] = rule.parts[ 1 ];
      Severity: Major
      Found in lib/rules/Border Radius Combinations.js - About 45 mins to fix

        Similar blocks of code found in 5 locations. Consider refactoring.
        Open

                            if ( rule !== first && rule.position && first.position ) {
                        compressor.log(
                            "Combining '" + rule.property + "' on line " + rule.position.start.line +
                            " with '" + graph.shorthand + "' on line " + first.position.start.line,
                            [ rule.position, first.position ]
        Severity: Major
        Found in lib/rules/Border Radius Combinations.js and 4 other locations - About 3 hrs to fix
        lib/rules/Border, Outline Style Combinations.js on lines 80..86
        lib/rules/Font Combinations.js on lines 82..88
        lib/rules/List Style Combinations.js on lines 79..85
        lib/rules/Margin, Padding Combinations.js on lines 100..106

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 112.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                            else if ( rule.property == graph.topright ) {
                        if ( rule.parts.length == 2 ) {
                            separator = true;
                            sections[ 0 ][ 1 ] = rule.parts[ 0 ];
                            sections[ 1 ][ 1 ] = rule.parts[ 1 ];
        Severity: Major
        Found in lib/rules/Border Radius Combinations.js and 2 other locations - About 3 hrs to fix
        lib/rules/Border Radius Combinations.js on lines 127..169
        lib/rules/Border Radius Combinations.js on lines 149..169

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                            else if ( rule.property == graph.bottomright ) {
                        if ( rule.parts.length == 2 ) {
                            separator = true;
                            sections[ 0 ][ 2 ] = rule.parts[ 0 ];
                            sections[ 1 ][ 2 ] = rule.parts[ 1 ];
        Severity: Major
        Found in lib/rules/Border Radius Combinations.js and 2 other locations - About 3 hrs to fix
        lib/rules/Border Radius Combinations.js on lines 127..169
        lib/rules/Border Radius Combinations.js on lines 138..169

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

                            else if ( rule.property == graph.topleft ) {
                        if ( rule.parts.length == 2 ) {
                            separator = true;
                            sections[ 0 ][ 0 ] = rule.parts[ 0 ];
                            sections[ 1 ][ 0 ] = rule.parts[ 1 ];
        Severity: Major
        Found in lib/rules/Border Radius Combinations.js and 2 other locations - About 3 hrs to fix
        lib/rules/Border Radius Combinations.js on lines 138..169
        lib/rules/Border Radius Combinations.js on lines 149..169

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 105.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 2 locations. Consider refactoring.
        Open

                            if ( section[ 0 ] === section[ 1 ] && section[ 1 ] === section[ 2 ] && section[ 2 ] === section[ 3 ] ) {
                        section = [ section[ 0 ] ];
                    }
                    // '3px 2px 3px 2px' => '3px 2px'
                    else if ( section [ 0 ] === section[ 2 ] && section[ 1 ] === section[ 3 ] ) {
        Severity: Major
        Found in lib/rules/Border Radius Combinations.js and 1 other location - About 2 hrs to fix
        lib/rules/Margin, Padding Combinations.js on lines 111..121

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 90.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                                    if ( parts.length === 1 ) {
                                parts.push( parts[ 0 ] );
                                parts.push( parts[ 0 ] );
                                parts.push( parts[ 0 ] );
                            }
        Severity: Minor
        Found in lib/rules/Border Radius Combinations.js and 1 other location - About 40 mins to fix
        lib/rules/Margin, Padding Combinations.js on lines 73..84

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 49.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status