Sign upLogin

coding-chimp/TalesOfInterest

View on GitHub
Star

Showing 8 of 8 total issues

Class EpisodePresenter has 21 methods (exceeds 20 allowed). Consider refactoring.
Open

class EpisodePresenter < BasePresenter
  presents :episode
  delegate :title, :num, :full_title, :file_url, to: :episode

  def linked_podcast_name
Severity: Minor
Found in app/presenters/episode_presenter.rb - About 2 hrs to fix

    Method find_audio_file has a Cognitive Complexity of 10 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.find_audio_file(name)
    type = File.extname(name)
    podcast_name = File.basename(name, type).titleize
    episode_num = podcast_name[-3..-1].to_i
    podcast_name = podcast_name[0..-4]
    Severity: Minor
    Found in app/models/download_data.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method process_data has a Cognitive Complexity of 7 (exceeds 5 allowed). Consider refactoring.
    Open

      def self.process_data(rows, date)
    @data = {}
    
    rows.each do |row|
      name = row['c'][0]['v'][1..-1]
    Severity: Minor
    Found in app/models/download_data.rb - About 35 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method since_color_code has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

      def since_color_code(episode)
    if episode
      distance = Date.today - episode.published_at.to_date
      if distance <= 14
        "ok"
    Severity: Minor
    Found in app/presenters/podcast_presenter.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method create has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def create
        podcast = Podcast.find(params[:podcast])
        @episode = Episode.includes(:podcast, :show_notes).new(params[:episode])

        params[:episode][:draft] = false if params[:publish]
    Severity: Minor
    Found in app/controllers/episodes_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method update has a Cognitive Complexity of 6 (exceeds 5 allowed). Consider refactoring.
    Open

        def update
        podcast = Podcast.find(params[:podcast])
        @episode = podcast.episodes.find(params[:id])

        params[:episode][:draft] = false if params[:publish]
    Severity: Minor
    Found in app/controllers/episodes_controller.rb - About 25 mins to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def import_xml
        if params[:import] == nil
            flash[:error] = "Choose a xml file."
            render 'import_form'
        else
    Severity: Minor
    Found in app/controllers/podcasts_controller.rb and 1 other location - About 20 mins to fix
    app/controllers/pages_controller.rb on lines 57..64

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Similar blocks of code found in 2 locations. Consider refactoring.
    Open

        def import_xml
        if params[:import] == nil
            flash[:error] = "Choose a xml file."
            render 'import_form'
        else
    Severity: Minor
    Found in app/controllers/pages_controller.rb and 1 other location - About 20 mins to fix
    app/controllers/podcasts_controller.rb on lines 65..72

    Duplicated Code

    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

    Tuning

    This issue has a mass of 27.

    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

    Refactorings

    Further Reading

    Severity
    Category
    Status
    Source
    Language