cofiem/clearly-query

View on GitHub
lib/clearly/query/graph.rb

Summary

Maintainability
A
2 hrs
Test Coverage

Method has too many lines. [17/10]
Open

      def traverse_branches(current_node, current_path)
        child_nodes = current_node.include?(@child_key) ? current_node[@child_key] : []

        current_node_no_children = current_node.dup.except(@child_key)

Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

This cop checks if the length of a method exceeds some maximum value. Comment lines can optionally be ignored. The maximum allowed length is configurable.

Assignment Branch Condition size for traverse_branches is too high. [21.21/15]
Open

      def traverse_branches(current_node, current_path)
        child_nodes = current_node.include?(@child_key) ? current_node[@child_key] : []

        current_node_no_children = current_node.dup.except(@child_key)

Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric

Method traverse_branches has a Cognitive Complexity of 17 (exceeds 5 allowed). Consider refactoring.
Open

      def traverse_branches(current_node, current_path)
        child_nodes = current_node.include?(@child_key) ? current_node[@child_key] : []

        current_node_no_children = current_node.dup.except(@child_key)

Severity: Minor
Found in lib/clearly/query/graph.rb - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Extra empty line detected at module body beginning.
Open


    # Stores a graph and provides methods to operate on the graph.
Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

This cops checks if empty lines around the bodies of modules match the configuration.

Example: EnforcedStyle: empty_lines

# good

module Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

module Foo
  module Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
module Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

module Foo
  def bar
    # ...
  end
end

Extra empty line detected at block body end.
Open


          end
Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

This cops checks if empty lines around the bodies of blocks match the configuration.

Example: EnforcedStyle: empty_lines

# good

foo do |bar|

  # ...

end

Example: EnforcedStyle: noemptylines (default)

# good

foo do |bar|
  # ...
end

self used in void context.
Open

        self
Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

This cop checks for operators, variables and literals used in void context.

Example:

# bad

def some_method
  some_num * 10
  do_something
end

Example:

# bad

def some_method(some_var)
  some_var
  do_something
end

Example:

# good

def some_method
  do_something
  some_num * 10
end

Example:

# good

def some_method(some_var)
  do_something
  some_var
end

Use next to skip iteration.
Open

            unless @discovered_nodes.include?(child_node_no_children)
Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

Use next to skip iteration instead of a condition at the end.

Example: EnforcedStyle: skipmodifierifs (default)

# bad
[1, 2].each do |a|
  if a == 1
    puts a
  end
end

# good
[1, 2].each do |a|
  next unless a == 1
  puts a
end

# good
[1, 2].each do |o|
  puts o unless o == 1
end

Example: EnforcedStyle: always

# With `always` all conditions at the end of an iteration needs to be
# replaced by next - with `skip_modifier_ifs` the modifier if like
# this one are ignored: `[1, 2].each { |a| return 'yes' if a == 1 }`

# bad
[1, 2].each do |o|
  puts o unless o == 1
end

# bad
[1, 2].each do |a|
  if a == 1
    puts a
  end
end

# good
[1, 2].each do |a|
  next unless a == 1
  puts a
end

Extra empty line detected at class body beginning.
Open


      # root node
Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

Extra blank line detected.
Open


        if child_nodes.size > 0
Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

This cops checks for two or more consecutive blank lines.

Example:

# bad - It has two empty lines.
some_method
# one empty line
# two empty lines
some_method

# good
some_method
# one empty line
some_method

Final newline missing.
Open

end
Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

Line is too long. [83/80]
Open

    # Graph nodes are a hash, and one special key contains an array of child nodes.
Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

Line is too long. [87/80]
Open

        child_nodes = current_node.include?(@child_key) ? current_node[@child_key] : []
Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

Use !empty? instead of size > 0.
Open

        if child_nodes.size > 0
Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

This cop checks for numeric comparisons that can be replaced by a predicate method, such as receiver.length == 0, receiver.length > 0, receiver.length != 0, receiver.length < 1 and receiver.size == 0 that can be replaced by receiver.empty? and !receiver.empty.

Example:

# bad
[1, 2, 3].length == 0
0 == "foobar".length
array.length < 1
{a: 1, b: 2}.length != 0
string.length > 0
hash.size > 0

# good
[1, 2, 3].empty?
"foobar".empty?
array.empty?
!{a: 1, b: 2}.empty?
!string.empty?
!hash.empty?

Extra empty line detected at class body end.
Open


    end
Severity: Minor
Found in lib/clearly/query/graph.rb by rubocop

This cops checks if empty lines around the bodies of classes match the configuration.

Example: EnforcedStyle: empty_lines

# good

class Foo

  def bar
    # ...
  end

end

Example: EnforcedStyle: emptylinesexcept_namespace

# good

class Foo
  class Bar

    # ...

  end
end

Example: EnforcedStyle: emptylinesspecial

# good
class Foo

  def bar; end

end

Example: EnforcedStyle: noemptylines (default)

# good

class Foo
  def bar
    # ...
  end
end

There are no issues that match your filters.

Category
Status