coi-gov-pl/puppet-jboss

View on GitHub
lib/puppet_x/coi/jboss/provider/confignode.rb

Summary

Maintainability
C
1 day
Test Coverage

Method ensure has 40 lines of code (exceeds 25 allowed). Consider refactoring.
Open

  def ensure
    trace 'ensure'

    exists?
    if @data.nil?
Severity: Minor
Found in lib/puppet_x/coi/jboss/provider/confignode.rb - About 1 hr to fix

    Method exists? has a Cognitive Complexity of 13 (exceeds 5 allowed). Consider refactoring.
    Open

      def exists?
        trace 'exists?'
        if @clean
          return (not @data.nil?)
        end
    Severity: Minor
    Found in lib/puppet_x/coi/jboss/provider/confignode.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method ensure has a Cognitive Complexity of 12 (exceeds 5 allowed). Consider refactoring.
    Open

      def ensure
        trace 'ensure'
    
        exists?
        if @data.nil?
    Severity: Minor
    Found in lib/puppet_x/coi/jboss/provider/confignode.rb - About 1 hr to fix

    Cognitive Complexity

    Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

    A method's cognitive complexity is based on a few simple rules:

    • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
    • Code is considered more complex for each "break in the linear flow of the code"
    • Code is considered more complex when "flow breaking structures are nested"

    Further reading

    Method exists? has 33 lines of code (exceeds 25 allowed). Consider refactoring.
    Open

      def exists?
        trace 'exists?'
        if @clean
          return (not @data.nil?)
        end
    Severity: Minor
    Found in lib/puppet_x/coi/jboss/provider/confignode.rb - About 1 hr to fix

      Method properties= has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def properties= newprops
          trace 'properties=(%s)' % newprops.inspect
      
          # Sorting by value to process `nil` values first
          sorted = newprops.sort do |a, b|
      Severity: Minor
      Found in lib/puppet_x/coi/jboss/provider/confignode.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Method properties has a Cognitive Complexity of 9 (exceeds 5 allowed). Consider refactoring.
      Open

        def properties
          trace 'properties()'
      
          if @data.nil?
            traceout 'properties()', {}
      Severity: Minor
      Found in lib/puppet_x/coi/jboss/provider/confignode.rb - About 55 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Avoid too many return statements within this method.
      Open

              return :enabled
      Severity: Major
      Found in lib/puppet_x/coi/jboss/provider/confignode.rb - About 30 mins to fix

        Avoid too many return statements within this method.
        Open

                return :disabled
        Severity: Major
        Found in lib/puppet_x/coi/jboss/provider/confignode.rb - About 30 mins to fix

          Avoid too many return statements within this method.
          Open

                return :present
          Severity: Major
          Found in lib/puppet_x/coi/jboss/provider/confignode.rb - About 30 mins to fix

            There are no issues that match your filters.

            Category
            Status