comm-network/mastodon

View on GitHub
app/lib/user_settings_decorator.rb

Summary

Maintainability
A
0 mins
Test Coverage

Cyclomatic complexity for process_update is too high. [28/25]
Open

  def process_update
    user.settings['notification_emails']  = merged_notification_emails if change?('notification_emails')
    user.settings['interactions']         = merged_interactions if change?('interactions')
    user.settings['default_privacy']      = default_privacy_preference if change?('setting_default_privacy')
    user.settings['default_sensitive']    = default_sensitive_preference if change?('setting_default_sensitive')
Severity: Minor
Found in app/lib/user_settings_decorator.rb by rubocop

This cop checks that the cyclomatic complexity of methods is not higher than the configured maximum. The cyclomatic complexity is the number of linearly independent paths through a method. The algorithm counts decision points and adds one.

An if statement (or unless or ?:) increases the complexity by one. An else branch does not, since it doesn't add a decision point. The && operator (or keyword and) can be converted to a nested if statement, and ||/or is shorthand for a sequence of ifs, so they also add one. Loops can be said to have an exit condition, so they add one. Blocks that are calls to builtin iteration methods (e.g. `ary.map{...}) also add one, others are ignored.

def each_child_node(*types)               # count begins: 1
  unless block_given?                     # unless: +1
    return to_enum(__method__, *types)

  children.each do |child|                # each{}: +1
    next unless child.is_a?(Node)         # unless: +1

    yield child if types.empty? ||        # if: +1, ||: +1
                   types.include?(child.type)
  end

  self
end                                       # total: 6

Perceived complexity for process_update is too high. [28/25]
Open

  def process_update
    user.settings['notification_emails']  = merged_notification_emails if change?('notification_emails')
    user.settings['interactions']         = merged_interactions if change?('interactions')
    user.settings['default_privacy']      = default_privacy_preference if change?('setting_default_privacy')
    user.settings['default_sensitive']    = default_sensitive_preference if change?('setting_default_sensitive')
Severity: Minor
Found in app/lib/user_settings_decorator.rb by rubocop

This cop tries to produce a complexity score that's a measure of the complexity the reader experiences when looking at a method. For that reason it considers when nodes as something that doesn't add as much complexity as an if or a &&. Except if it's one of those special case/when constructs where there's no expression after case. Then the cop treats it as an if/elsif/elsif... and lets all the when nodes count. In contrast to the CyclomaticComplexity cop, this cop considers else nodes as adding complexity.

Example:

def my_method                   # 1
  if cond                       # 1
    case var                    # 2 (0.8 + 4 * 0.2, rounded)
    when 1 then func_one
    when 2 then func_two
    when 3 then func_three
    when 4..10 then func_other
    end
  else                          # 1
    do_something until a && b   # 2
  end                           # ===
end                             # 7 complexity points

Assignment Branch Condition size for process_update is too high. [<27, 108, 27> 114.6/100]
Open

  def process_update
    user.settings['notification_emails']  = merged_notification_emails if change?('notification_emails')
    user.settings['interactions']         = merged_interactions if change?('interactions')
    user.settings['default_privacy']      = default_privacy_preference if change?('setting_default_privacy')
    user.settings['default_sensitive']    = default_sensitive_preference if change?('setting_default_sensitive')
Severity: Minor
Found in app/lib/user_settings_decorator.rb by rubocop

This cop checks that the ABC size of methods is not higher than the configured maximum. The ABC size is based on assignments, branches (method calls), and conditions. See http://c2.com/cgi/wiki?AbcMetric and https://en.wikipedia.org/wiki/ABC_Software_Metric.

There are no issues that match your filters.

Category
Status