conan-io/conan

View on GitHub
conan/tools/build/cppstd.py

Summary

Maintainability
F
3 days
Test Coverage

Avoid too many return statements within this function.
Open

    return ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17", "20", "gnu20", "23", "gnu23"]
Severity: Major
Found in conan/tools/build/cppstd.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

            return ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17", "20", "gnu20"]
    Severity: Major
    Found in conan/tools/build/cppstd.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17", "20", "gnu20"]
      Severity: Major
      Found in conan/tools/build/cppstd.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

            return ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17", "20", "gnu20", "23", "gnu23"]
        Severity: Major
        Found in conan/tools/build/cppstd.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

              return ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17", "20", "gnu20", "23", "gnu23"]
          Severity: Major
          Found in conan/tools/build/cppstd.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                    return ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17"]
            Severity: Major
            Found in conan/tools/build/cppstd.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                      return ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17", "20", "gnu20"]
              Severity: Major
              Found in conan/tools/build/cppstd.py - About 30 mins to fix

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                def _clang_supported_cppstd(version):
                    """
                    ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17", "20", "gnu20", "23", "gnu23"]
                    """
                    if version < "2.1":
                Severity: Major
                Found in conan/tools/build/cppstd.py and 1 other location - About 1 day to fix
                conan/tools/build/cppstd.py on lines 121..136

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 122.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                def _apple_clang_supported_cppstd(version):
                    """
                    ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17", "20", "gnu20"]
                    """
                    if version < "4.0":
                Severity: Major
                Found in conan/tools/build/cppstd.py and 1 other location - About 1 day to fix
                conan/tools/build/cppstd.py on lines 173..188

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 122.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Identical blocks of code found in 2 locations. Consider refactoring.
                Open

                    def less_than(lhs, rhs):
                        def extract_cpp_version(_cppstd):
                            return str(_cppstd).replace("gnu", "")
                
                        def add_millennium(_cppstd):
                Severity: Major
                Found in conan/tools/build/cppstd.py and 1 other location - About 5 hrs to fix
                conans/client/tools/settings.py on lines 25..34

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 95.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                    default = {"gcc": _gcc_cppstd_default(compiler_version),
                               "clang": _clang_cppstd_default(compiler_version),
                               "apple-clang": "gnu98",
                               # Confirmed in apple-clang 9.1 with a simple "auto i=1;"; 14.0 still the same
                               "Visual Studio": _visual_cppstd_default(compiler_version),
                Severity: Major
                Found in conan/tools/build/cppstd.py and 1 other location - About 2 hrs to fix
                conans/client/build/cppstd_flags.py on lines 59..64

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 50.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Similar blocks of code found in 2 locations. Consider refactoring.
                Open

                def valid_min_cppstd(conanfile, cppstd, gnu_extensions=False):
                    """ Validate if current cppstd fits the minimal version required.
                
                    :param conanfile: The current recipe object. Always use ``self``.
                    :param cppstd: Minimal cppstd version required
                Severity: Minor
                Found in conan/tools/build/cppstd.py and 1 other location - About 45 mins to fix
                conans/client/tools/settings.py on lines 65..77

                Duplicated Code

                Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                Tuning

                This issue has a mass of 35.

                We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                Refactorings

                Further Reading

                Line too long (101 > 100 characters)
                Open

                    return ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17", "20", "gnu20", "23", "gnu23"]
                Severity: Minor
                Found in conan/tools/build/cppstd.py by pep8

                Limit all lines to a maximum of 79 characters.

                There are still many devices around that are limited to 80 character
                lines; plus, limiting windows to 80 characters makes it possible to
                have several windows side-by-side.  The default wrapping on such
                devices looks ugly.  Therefore, please limit all lines to a maximum
                of 79 characters. For flowing long blocks of text (docstrings or
                comments), limiting the length to 72 characters is recommended.
                
                Reports error E501.

                Line too long (101 > 100 characters)
                Open

                    return ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17", "20", "gnu20", "23", "gnu23"]
                Severity: Minor
                Found in conan/tools/build/cppstd.py by pep8

                Limit all lines to a maximum of 79 characters.

                There are still many devices around that are limited to 80 character
                lines; plus, limiting windows to 80 characters makes it possible to
                have several windows side-by-side.  The default wrapping on such
                devices looks ugly.  Therefore, please limit all lines to a maximum
                of 79 characters. For flowing long blocks of text (docstrings or
                comments), limiting the length to 72 characters is recommended.
                
                Reports error E501.

                Expected 1 blank line before a nested definition, found 0
                Open

                    def _msvc_cppstd_default(compiler_version):
                Severity: Minor
                Found in conan/tools/build/cppstd.py by pep8

                Separate top-level function and class definitions with two blank lines.

                Method definitions inside a class are separated by a single blank
                line.
                
                Extra blank lines may be used (sparingly) to separate groups of
                related functions.  Blank lines may be omitted between a bunch of
                related one-liners (e.g. a set of dummy implementations).
                
                Use blank lines in functions, sparingly, to indicate logical
                sections.
                
                Okay: def a():\n    pass\n\n\ndef b():\n    pass
                Okay: def a():\n    pass\n\n\nasync def b():\n    pass
                Okay: def a():\n    pass\n\n\n# Foo\n# Bar\n\ndef b():\n    pass
                Okay: default = 1\nfoo = 1
                Okay: classify = 1\nfoo = 1
                
                E301: class Foo:\n    b = 0\n    def bar():\n        pass
                E302: def a():\n    pass\n\ndef b(n):\n    pass
                E302: def a():\n    pass\n\nasync def b(n):\n    pass
                E303: def a():\n    pass\n\n\n\ndef b(n):\n    pass
                E303: def a():\n\n\n\n    pass
                E304: @decorator\n\ndef a():\n    pass
                E305: def a():\n    pass\na()
                E306: def a():\n    def b():\n        pass\n    def c():\n        pass

                Line too long (101 > 100 characters)
                Open

                    return ["98", "gnu98", "11", "gnu11", "14", "gnu14", "17", "gnu17", "20", "gnu20", "23", "gnu23"]
                Severity: Minor
                Found in conan/tools/build/cppstd.py by pep8

                Limit all lines to a maximum of 79 characters.

                There are still many devices around that are limited to 80 character
                lines; plus, limiting windows to 80 characters makes it possible to
                have several windows side-by-side.  The default wrapping on such
                devices looks ugly.  Therefore, please limit all lines to a maximum
                of 79 characters. For flowing long blocks of text (docstrings or
                comments), limiting the length to 72 characters is recommended.
                
                Reports error E501.

                There are no issues that match your filters.

                Category
                Status