conan-io/conan

View on GitHub
conan/tools/qbs/qbsprofile.py

Summary

Maintainability
B
5 hrs
Test Coverage

Avoid deeply nested control flow statements.
Open

                    if (temp_value.isnumeric() or
                            temp_value in ['true', 'false', 'undefined']):
                        value = temp_value
                config[key] = value
Severity: Major
Found in conan/tools/qbs/qbsprofile.py - About 45 mins to fix

    Avoid too many return statements within this function.
    Open

        return compiler
    Severity: Major
    Found in conan/tools/qbs/qbsprofile.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return 'clang-cl'
      Severity: Major
      Found in conan/tools/qbs/qbsprofile.py - About 30 mins to fix

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            if tools.get_env('CPPFLAGS'):
                flags_from_env['cpp.cppFlags'] = '%s' % (
                    _env_var_to_list(tools.get_env('CPPFLAGS')))
        Severity: Major
        Found in conan/tools/qbs/qbsprofile.py and 3 other locations - About 55 mins to fix
        conan/tools/qbs/qbsprofile.py on lines 186..188
        conan/tools/qbs/qbsprofile.py on lines 189..191
        conan/tools/qbs/qbsprofile.py on lines 195..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 37.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            if tools.get_env('CXXFLAGS'):
                flags_from_env['cpp.cxxFlags'] = '%s' % (
                    _env_var_to_list(tools.get_env('CXXFLAGS')))
        Severity: Major
        Found in conan/tools/qbs/qbsprofile.py and 3 other locations - About 55 mins to fix
        conan/tools/qbs/qbsprofile.py on lines 186..188
        conan/tools/qbs/qbsprofile.py on lines 189..191
        conan/tools/qbs/qbsprofile.py on lines 192..194

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 37.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            if tools.get_env('ASFLAGS'):
                flags_from_env['cpp.assemblerFlags'] = '%s' % (
                    _env_var_to_list(tools.get_env('ASFLAGS')))
        Severity: Major
        Found in conan/tools/qbs/qbsprofile.py and 3 other locations - About 55 mins to fix
        conan/tools/qbs/qbsprofile.py on lines 189..191
        conan/tools/qbs/qbsprofile.py on lines 192..194
        conan/tools/qbs/qbsprofile.py on lines 195..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 37.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 4 locations. Consider refactoring.
        Open

            if tools.get_env('CFLAGS'):
                flags_from_env['cpp.cFlags'] = '%s' % (
                    _env_var_to_list(tools.get_env('CFLAGS')))
        Severity: Major
        Found in conan/tools/qbs/qbsprofile.py and 3 other locations - About 55 mins to fix
        conan/tools/qbs/qbsprofile.py on lines 186..188
        conan/tools/qbs/qbsprofile.py on lines 192..194
        conan/tools/qbs/qbsprofile.py on lines 195..197

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 37.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Continuation line unaligned for hanging indent
        Open

                        self._profile_values_from_setup.get("qbs.architecture") else None,
        Severity: Minor
        Found in conan/tools/qbs/qbsprofile.py by pep8

        Continuation lines indentation.

        Continuation lines should align wrapped elements either vertically
        using Python's implicit line joining inside parentheses, brackets
        and braces, or using a hanging indent.
        
        When using a hanging indent these considerations should be applied:
        - there should be no arguments on the first line, and
        - further indentation should be used to clearly distinguish itself
          as a continuation line.
        
        Okay: a = (\n)
        E123: a = (\n    )
        
        Okay: a = (\n    42)
        E121: a = (\n   42)
        E122: a = (\n42)
        E123: a = (\n    42\n    )
        E124: a = (24,\n     42\n)
        E125: if (\n    b):\n    pass
        E126: a = (\n        42)
        E127: a = (24,\n      42)
        E128: a = (24,\n    42)
        E129: if (a or\n    b):\n    pass
        E131: a = (\n    42\n 24)

        There are no issues that match your filters.

        Category
        Status