Sign upLogin

conan-io/conan

View on GitHub
Star
conans/client/build/cmake.py

Summary

Maintainability
A
3 hrs
Test Coverage

Function _build has a Cognitive Complexity of 29 (exceeds 20 allowed). Consider refactoring.
Open

    def _build(self, args=None, build_dir=None, target=None):
        args = args or []
        build_dir = build_dir or self.build_dir or self._conanfile.build_folder
        if target is not None:
            args = ["--target", target] + args
Severity: Minor
Found in conans/client/build/cmake.py - About 1 hr to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid deeply nested control flow statements.
Open

                        if ret:
                            self._conanfile.output.info("Patched paths for %s: %s to %s"
                                                        % (dep, from_str, dep_str))
Severity: Major
Found in conans/client/build/cmake.py - About 45 mins to fix

    Function __init__ has 12 arguments (exceeds 10 allowed). Consider refactoring.
    Open

        def __init__(self, conanfile, generator=None, cmake_system_name=True,
    Severity: Major
    Found in conans/client/build/cmake.py - About 45 mins to fix

      Function command_line has a Cognitive Complexity of 22 (exceeds 20 allowed). Consider refactoring.
      Open

          def command_line(self):
        if self.generator_platform and not is_generator_platform_supported(self.generator):
            raise ConanException('CMake does not support generator platform with generator '
                                 '"%s:. Please check your conan profile to either remove the '
                                 'generator platform, or change the CMake generator.'
      Severity: Minor
      Found in conans/client/build/cmake.py - About 35 mins to fix

      Cognitive Complexity

      Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

      A method's cognitive complexity is based on a few simple rules:

      • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
      • Code is considered more complex for each "break in the linear flow of the code"
      • Code is considered more complex when "flow breaking structures are nested"

      Further reading

      Line too long (101 > 100 characters)
      Open

                      vcvars_dict = tools.vcvars_dict(self._settings, force=True, filter_known_paths=False,
      Severity: Minor
      Found in conans/client/build/cmake.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
lines; plus, limiting windows to 80 characters makes it possible to
have several windows side-by-side.  The default wrapping on such
devices looks ugly.  Therefore, please limit all lines to a maximum
of 79 characters. For flowing long blocks of text (docstrings or
comments), limiting the length to 72 characters is recommended.

Reports error E501.

      There are no issues that match your filters.

      Category
      Status