conan-io/conan

View on GitHub
conans/client/build/cmake_flags.py

Summary

Maintainability
C
1 day
Test Coverage

Function _cmake_cross_build_defines has a Cognitive Complexity of 43 (exceeds 20 allowed). Consider refactoring.
Open

    def _cmake_cross_build_defines(self, cmake_version):
        os_ = self._ss("os")
        arch = self._ss("arch")
        os_ver_str = "os.api_level" if os_ == "Android" else "os.version"
        op_system_version = self._ss(os_ver_str)
Severity: Minor
Found in conans/client/build/cmake_flags.py - About 4 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function get_definitions has a Cognitive Complexity of 36 (exceeds 20 allowed). Consider refactoring.
Open

    def get_definitions(self, cmake_version):

        compiler = self._ss("compiler")
        compiler_base = self._ss("compiler.base")
        compiler_version = self._ss("compiler.version")
Severity: Minor
Found in conans/client/build/cmake_flags.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

        return base
Severity: Major
Found in conans/client/build/cmake_flags.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

        return "Unix Makefiles"
    Severity: Major
    Found in conans/client/build/cmake_flags.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

              return "MinGW Makefiles"  # it is valid only under Windows
      Severity: Major
      Found in conans/client/build/cmake_flags.py - About 30 mins to fix

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        def is_multi_configuration(generator):
            if not generator:
                return False
            return "Visual" in generator or "Xcode" in generator or "Multi-Config" in generator
        Severity: Major
        Found in conans/client/build/cmake_flags.py and 2 other locations - About 1 hr to fix
        conan/tools/cmake/utils.py on lines 4..7
        conans/client/build/cmake_flags.py on lines 114..118

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Similar blocks of code found in 3 locations. Consider refactoring.
        Open

        def is_toolset_supported(generator):
            # https://cmake.org/cmake/help/v3.14/variable/CMAKE_GENERATOR_TOOLSET.html
            if not generator:
                return False
            return "Visual" in generator or "Xcode" in generator or "Green Hills MULTI" in generator
        Severity: Major
        Found in conans/client/build/cmake_flags.py and 2 other locations - About 1 hr to fix
        conan/tools/cmake/utils.py on lines 4..7
        conans/client/build/cmake_flags.py on lines 108..111

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 44.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        Identical blocks of code found in 2 locations. Consider refactoring.
        Open

                if compiler_version:
                    compiler_version = compiler_version if "." in compiler_version else \
                        "%s.0" % compiler_version
                    return "Intel C++ Compiler " + compiler_version
        Severity: Minor
        Found in conans/client/build/cmake_flags.py and 1 other location - About 35 mins to fix
        conan/tools/microsoft/toolchain.py on lines 94..97

        Duplicated Code

        Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

        Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

        When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

        Tuning

        This issue has a mass of 33.

        We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

        The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

        If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

        See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

        Refactorings

        Further Reading

        There are no issues that match your filters.

        Category
        Status