conan-io/conan

View on GitHub
conans/client/build/msbuild.py

Summary

Maintainability
B
5 hrs
Test Coverage

Function get_command has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

    def get_command(self, project_file, props_file_path=None, targets=None, upgrade_project=True,
                    build_type=None, arch=None, parallel=True, toolset=None, platforms=None,
                    use_env=False, properties=None, output_binary_log=None, verbosity=None,
                    user_property_file_name=None):

Severity: Minor
Found in conans/client/build/msbuild.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build has 18 arguments (exceeds 10 allowed). Consider refactoring.
Open

    def build(self, project_file, targets=None, upgrade_project=True, build_type=None, arch=None,
Severity: Major
Found in conans/client/build/msbuild.py - About 1 hr to fix

    Function get_command has 14 arguments (exceeds 10 allowed). Consider refactoring.
    Open

        def get_command(self, project_file, props_file_path=None, targets=None, upgrade_project=True,
    Severity: Major
    Found in conans/client/build/msbuild.py - About 1 hr to fix

      Continuation line with same indent as next logical line
      Open

                      self._conanfile.settings.get_safe("compiler.base") == "Visual Studio":
      Severity: Minor
      Found in conans/client/build/msbuild.py by pep8

      Continuation lines indentation.

      Continuation lines should align wrapped elements either vertically
      using Python's implicit line joining inside parentheses, brackets
      and braces, or using a hanging indent.
      
      When using a hanging indent these considerations should be applied:
      - there should be no arguments on the first line, and
      - further indentation should be used to clearly distinguish itself
        as a continuation line.
      
      Okay: a = (\n)
      E123: a = (\n    )
      
      Okay: a = (\n    42)
      E121: a = (\n   42)
      E122: a = (\n42)
      E123: a = (\n    42\n    )
      E124: a = (24,\n     42\n)
      E125: if (\n    b):\n    pass
      E126: a = (\n        42)
      E127: a = (24,\n      42)
      E128: a = (24,\n    42)
      E129: if (a or\n    b):\n    pass
      E131: a = (\n    42\n 24)

      Line too long (109 > 100 characters)
      Open

                      wrong_helper_msg = "Using the wrong 'MSBuild' helper. To use MSBuildDeps, MSBuildToolchain "\
      Severity: Minor
      Found in conans/client/build/msbuild.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      Line too long (103 > 100 characters)
      Open

                                         "Set environment variable CONAN_DISABLE_STRICT_MODE=1 to override "\
      Severity: Minor
      Found in conans/client/build/msbuild.py by pep8

      Limit all lines to a maximum of 79 characters.

      There are still many devices around that are limited to 80 character
      lines; plus, limiting windows to 80 characters makes it possible to
      have several windows side-by-side.  The default wrapping on such
      devices looks ugly.  Therefore, please limit all lines to a maximum
      of 79 characters. For flowing long blocks of text (docstrings or
      comments), limiting the length to 72 characters is recommended.
      
      Reports error E501.

      There are no issues that match your filters.

      Category
      Status