conan-io/conan

View on GitHub
conans/client/build/msbuild.py

Summary

Maintainability
B
6 hrs
Test Coverage

Function get_command has a Cognitive Complexity of 35 (exceeds 20 allowed). Consider refactoring.
Open

    def get_command(self, project_file, props_file_path=None, targets=None, upgrade_project=True,
                    build_type=None, arch=None, parallel=True, toolset=None, platforms=None,
                    use_env=False, properties=None, output_binary_log=None, verbosity=None,
                    user_property_file_name=None):

Severity: Minor
Found in conans/client/build/msbuild.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function build has 18 arguments (exceeds 10 allowed). Consider refactoring.
Open

    def build(self, project_file, targets=None, upgrade_project=True, build_type=None, arch=None,
Severity: Major
Found in conans/client/build/msbuild.py - About 1 hr to fix

    Function get_command has 14 arguments (exceeds 10 allowed). Consider refactoring.
    Open

        def get_command(self, project_file, props_file_path=None, targets=None, upgrade_project=True,
    Severity: Major
    Found in conans/client/build/msbuild.py - About 1 hr to fix

      Similar blocks of code found in 2 locations. Consider refactoring.
      Open

                  if self._conanfile.settings.get_safe("compiler") == "Intel" and \
                      self._conanfile.settings.get_safe("compiler.base") == "Visual Studio":
      Severity: Major
      Found in conans/client/build/msbuild.py and 1 other location - About 1 hr to fix
      conans/client/build/cmake.py on lines 82..83

      Duplicated Code

      Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

      Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

      When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

      Tuning

      This issue has a mass of 38.

      We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

      The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

      If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

      See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

      Refactorings

      Further Reading

      Continuation line with same indent as next logical line
      Open

                      self._conanfile.settings.get_safe("compiler.base") == "Visual Studio":
      Severity: Minor
      Found in conans/client/build/msbuild.py by pep8

      Continuation lines indentation.

      Continuation lines should align wrapped elements either vertically
      using Python's implicit line joining inside parentheses, brackets
      and braces, or using a hanging indent.
      
      When using a hanging indent these considerations should be applied:
      - there should be no arguments on the first line, and
      - further indentation should be used to clearly distinguish itself
        as a continuation line.
      
      Okay: a = (\n)
      E123: a = (\n    )
      
      Okay: a = (\n    42)
      E121: a = (\n   42)
      E122: a = (\n42)
      E123: a = (\n    42\n    )
      E124: a = (24,\n     42\n)
      E125: if (\n    b):\n    pass
      E126: a = (\n        42)
      E127: a = (24,\n      42)
      E128: a = (24,\n    42)
      E129: if (a or\n    b):\n    pass
      E131: a = (\n    42\n 24)

      There are no issues that match your filters.

      Category
      Status