conan-io/conan

View on GitHub
conans/client/cache/remote_registry.py

Summary

Maintainability
D
2 days
Test Coverage

Avoid deeply nested control flow statements.
Open

                        if metadata.recipe.remote == renamed:
                            metadata.recipe.remote = remote_name
                        for pkg_metadata in metadata.packages.values():
Severity: Major
Found in conans/client/cache/remote_registry.py - About 45 mins to fix

    Avoid deeply nested control flow statements.
    Open

                            if pkg_metadata.remote == remote_name:
                                pkg_metadata.remote = None
    
    
    Severity: Major
    Found in conans/client/cache/remote_registry.py - About 45 mins to fix

      Avoid deeply nested control flow statements.
      Open

                              for pkg_metadata in metadata.packages.values():
                                  if pkg_metadata.remote == renamed:
                                      pkg_metadata.remote = remote_name
      
      
      Severity: Major
      Found in conans/client/cache/remote_registry.py - About 45 mins to fix

        Avoid deeply nested control flow statements.
        Open

                                if pkg_metadata.remote == remote_name:
                                    pkg_metadata.remote = new_remote_name
        
        
        Severity: Major
        Found in conans/client/cache/remote_registry.py - About 45 mins to fix

          Avoid deeply nested control flow statements.
          Open

                                  if pkg_metadata.remote not in remotes:
                                      pkg_metadata.remote = None
          
          
          Severity: Major
          Found in conans/client/cache/remote_registry.py - About 45 mins to fix

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    with self._cache.editable_packages.disable_editables():
                        for ref in self._cache.all_refs():
                            with self._cache.package_layout(ref).update_metadata() as metadata:
                                if metadata.recipe.remote == remote_name:
                                    metadata.recipe.remote = None
            Severity: Major
            Found in conans/client/cache/remote_registry.py and 1 other location - About 6 hrs to fix
            conans/client/cache/remote_registry.py on lines 389..398

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            Similar blocks of code found in 2 locations. Consider refactoring.
            Open

                    with self._cache.editable_packages.disable_editables():
                        for ref in self._cache.all_refs():
                            with self._cache.package_layout(ref).update_metadata() as metadata:
                                if metadata.recipe.remote == remote_name:
                                    metadata.recipe.remote = new_remote_name
            Severity: Major
            Found in conans/client/cache/remote_registry.py and 1 other location - About 6 hrs to fix
            conans/client/cache/remote_registry.py on lines 362..371

            Duplicated Code

            Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

            Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

            When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

            Tuning

            This issue has a mass of 107.

            We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

            The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

            If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

            See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

            Refactorings

            Further Reading

            There are no issues that match your filters.

            Category
            Status