conan-io/conan

View on GitHub
conans/client/generators/__init__.py

Summary

Maintainability
D
1 day
Test Coverage

Function write_generators has a Cognitive Complexity of 31 (exceeds 20 allowed). Consider refactoring.
Open

    def write_generators(self, conanfile, old_gen_folder, new_gen_folder, output):
        """ produces auxiliary files, required to build a project or a package.
        """
        _receive_conf(conanfile)

Severity: Minor
Found in conans/client/generators/__init__.py - About 2 hrs to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Function _new_generator has a Cognitive Complexity of 23 (exceeds 20 allowed). Consider refactoring.
Open

    def _new_generator(self, generator_name, output):
        if generator_name not in self._new_generators:
            return
        if generator_name in self._generators:  # Avoid colisions with user custom generators
            msg = ("******* Your custom generator name '{}' is colliding with a new experimental "
Severity: Minor
Found in conans/client/generators/__init__.py - About 45 mins to fix

Cognitive Complexity

Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.

A method's cognitive complexity is based on a few simple rules:

  • Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
  • Code is considered more complex for each "break in the linear flow of the code"
  • Code is considered more complex when "flow breaking structures are nested"

Further reading

Avoid too many return statements within this function.
Open

            return XcodeToolchain
Severity: Major
Found in conans/client/generators/__init__.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return AutotoolsToolchain
    Severity: Major
    Found in conans/client/generators/__init__.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return BazelToolchain
      Severity: Major
      Found in conans/client/generators/__init__.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return PremakeDeps
        Severity: Major
        Found in conans/client/generators/__init__.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                      return VCVars
          Severity: Major
          Found in conans/client/generators/__init__.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return IntelCC
            Severity: Major
            Found in conans/client/generators/__init__.py - About 30 mins to fix

              Avoid too many return statements within this function.
              Open

                          return QbsProfile
              Severity: Major
              Found in conans/client/generators/__init__.py - About 30 mins to fix

                Avoid too many return statements within this function.
                Open

                            return BazelDeps
                Severity: Major
                Found in conans/client/generators/__init__.py - About 30 mins to fix

                  Avoid too many return statements within this function.
                  Open

                              return MesonDeps
                  Severity: Major
                  Found in conans/client/generators/__init__.py - About 30 mins to fix

                    Avoid too many return statements within this function.
                    Open

                                return VirtualBuildEnv
                    Severity: Major
                    Found in conans/client/generators/__init__.py - About 30 mins to fix

                      Avoid too many return statements within this function.
                      Open

                                  return MSBuildDeps
                      Severity: Major
                      Found in conans/client/generators/__init__.py - About 30 mins to fix

                        Avoid too many return statements within this function.
                        Open

                                    return AutotoolsDeps
                        Severity: Major
                        Found in conans/client/generators/__init__.py - About 30 mins to fix

                          Avoid too many return statements within this function.
                          Open

                                      return PkgConfigDeps
                          Severity: Major
                          Found in conans/client/generators/__init__.py - About 30 mins to fix

                            Avoid too many return statements within this function.
                            Open

                                        return MesonToolchain
                            Severity: Major
                            Found in conans/client/generators/__init__.py - About 30 mins to fix

                              Avoid too many return statements within this function.
                              Open

                                          return VirtualRunEnv
                              Severity: Major
                              Found in conans/client/generators/__init__.py - About 30 mins to fix

                                Avoid too many return statements within this function.
                                Open

                                            return XcodeDeps
                                Severity: Major
                                Found in conans/client/generators/__init__.py - About 30 mins to fix

                                  Avoid too many return statements within this function.
                                  Open

                                              return MSBuildToolchain
                                  Severity: Major
                                  Found in conans/client/generators/__init__.py - About 30 mins to fix

                                    Similar blocks of code found in 3 locations. Consider refactoring.
                                    Open

                                                save(os.path.join(conanfile.generators_folder, "deactivate_{}".format(filename)),
                                                     sh_content(deactivates(shs)))
                                    Severity: Minor
                                    Found in conans/client/generators/__init__.py and 2 other locations - About 35 mins to fix
                                    conans/client/generators/__init__.py on lines 305..306
                                    conans/client/generators/__init__.py on lines 312..313

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 33.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 3 locations. Consider refactoring.
                                    Open

                                                save(os.path.join(conanfile.generators_folder, "deactivate_{}".format(filename)),
                                                     ps1_content(deactivates(ps1s)))
                                    Severity: Minor
                                    Found in conans/client/generators/__init__.py and 2 other locations - About 35 mins to fix
                                    conans/client/generators/__init__.py on lines 298..299
                                    conans/client/generators/__init__.py on lines 305..306

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 33.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Similar blocks of code found in 3 locations. Consider refactoring.
                                    Open

                                                save(os.path.join(conanfile.generators_folder, "deactivate_{}".format(filename)),
                                                     bat_content(deactivates(bats)))
                                    Severity: Minor
                                    Found in conans/client/generators/__init__.py and 2 other locations - About 35 mins to fix
                                    conans/client/generators/__init__.py on lines 298..299
                                    conans/client/generators/__init__.py on lines 312..313

                                    Duplicated Code

                                    Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

                                    Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

                                    When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

                                    Tuning

                                    This issue has a mass of 33.

                                    We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

                                    The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

                                    If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

                                    See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

                                    Refactorings

                                    Further Reading

                                    Line too long (101 > 100 characters)
                                    Open

                                                                    "AutotoolsToolchain", "BazelDeps", "BazelToolchain", "PkgConfigDeps",
                                    Severity: Minor
                                    Found in conans/client/generators/__init__.py by pep8

                                    Limit all lines to a maximum of 79 characters.

                                    There are still many devices around that are limited to 80 character
                                    lines; plus, limiting windows to 80 characters makes it possible to
                                    have several windows side-by-side.  The default wrapping on such
                                    devices looks ugly.  Therefore, please limit all lines to a maximum
                                    of 79 characters. For flowing long blocks of text (docstrings or
                                    comments), limiting the length to 72 characters is recommended.
                                    
                                    Reports error E501.

                                    There are no issues that match your filters.

                                    Category
                                    Status