conan-io/conan

View on GitHub
conans/client/graph/graph.py

Summary

Maintainability
B
6 hrs
Test Coverage

Avoid too many return statements within this function.
Open

            return 1
Severity: Major
Found in conans/client/graph/graph.py - About 30 mins to fix

    Avoid too many return statements within this function.
    Open

                return -1
    Severity: Major
    Found in conans/client/graph/graph.py - About 30 mins to fix

      Avoid too many return statements within this function.
      Open

                  return -1
      Severity: Major
      Found in conans/client/graph/graph.py - About 30 mins to fix

        Avoid too many return statements within this function.
        Open

                    return 1
        Severity: Major
        Found in conans/client/graph/graph.py - About 30 mins to fix

          Avoid too many return statements within this function.
          Open

                  return 1
          Severity: Major
          Found in conans/client/graph/graph.py - About 30 mins to fix

            Avoid too many return statements within this function.
            Open

                        return -1
            Severity: Major
            Found in conans/client/graph/graph.py - About 30 mins to fix

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def __eq__(self, other):
                      return (self.ref == other.ref and
                              self.conanfile == other.conanfile and
                              self.context == other.context)
              Severity: Major
              Found in conans/client/graph/graph.py and 1 other location - About 1 hr to fix
              conans/model/requires.py on lines 64..67

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 46.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                  def __eq__(self, other):
                      return self.src == other.src and self.dst == other.dst
              Severity: Minor
              Found in conans/client/graph/graph.py and 1 other location - About 45 mins to fix
              conans/client/conf/compiler_id.py on lines 63..64

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              Similar blocks of code found in 2 locations. Consider refactoring.
              Open

                              if not any(n in opened for n in o_neighs):
                                  current_level.append(o)
              Severity: Minor
              Found in conans/client/graph/graph.py and 1 other location - About 45 mins to fix
              conans/model/graph_lock.py on lines 371..372

              Duplicated Code

              Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:

              Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.

              When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).

              Tuning

              This issue has a mass of 35.

              We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.

              The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.

              If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.

              See codeclimate-duplication's documentation for more information about tuning the mass threshold in your .codeclimate.yml.

              Refactorings

              Further Reading

              There are no issues that match your filters.

              Category
              Status