_expand_require has a Cognitive Complexity of 47 (exceeds 20 allowed). Consider refactoring. Open
def _expand_require(self, require, node, graph, check_updates, update, remotes, profile_host, profile_build, new_reqs, new_options, graph_lock, context_switch, populate_settings_target=True): # Handle a requirement of a node. There are 2 possibilities # node -(require)-> new_node (creates a new node in the graph)
- Read upRead up
Cognitive Complexity is a measure of how difficult a unit of code is to intuitively understand. Unlike Cyclomatic Complexity, which determines how difficult your code will be to test, Cognitive Complexity tells you how difficult your code will be to read and comprehend.
A method's cognitive complexity is based on a few simple rules:
- Code is not considered more complex when it uses shorthand that the language provides for collapsing multiple statements into one
- Code is considered more complex for each "break in the linear flow of the code"
- Code is considered more complex when "flow breaking structures are nested"
_expand_require has 13 arguments (exceeds 10 allowed). Consider refactoring. Open
def _expand_require(self, require, node, graph, check_updates, update, remotes, profile_host,
_create_new_node has 11 arguments (exceeds 10 allowed). Consider refactoring. Open
def _create_new_node(self, current_node, dep_graph, requirement, check_updates,
_expand_node has 11 arguments (exceeds 10 allowed). Consider refactoring. Open
def _expand_node(self, node, graph, down_reqs, down_ref, down_options, check_updates, update,
Similar blocks of code found in 3 locations. Consider refactoring. Open
def __init__(self, proxy, output, loader, resolver, recorder): self._proxy = proxy self._output = output self._loader = loader self._resolver = resolver
- Read upRead up
Duplicated code can lead to software that is hard to understand and difficult to change. The Don't Repeat Yourself (DRY) principle states:
Every piece of knowledge must have a single, unambiguous, authoritative representation within a system.
When you violate DRY, bugs and maintenance problems are sure to follow. Duplicated code has a tendency to both continue to replicate and also to diverge (leaving bugs as two similar implementations differ in subtle ways).
This issue has a mass of 46.
We set useful threshold defaults for the languages we support but you may want to adjust these settings based on your project guidelines.
The threshold configuration represents the minimum mass a code block must have to be analyzed for duplication. The lower the threshold, the more fine-grained the comparison.
If the engine is too easily reporting duplication, try raising the threshold. If you suspect that the engine isn't catching enough duplication, try lowering the threshold. The best setting tends to differ from language to language.
codeclimate-duplication's documentation for more information about tuning the mass threshold in your
- Extract Method
- Extract Class
- Form Template Method
- Introduce Null Object
- Pull Up Method
- Pull Up Field
- Substitute Algorithm
- Don't Repeat Yourself on the C2 Wiki
- Duplicated Code on SourceMaking
- Refactoring: Improving the Design of Existing Code by Martin Fowler. Duplicated Code, p76
Line too long (102 > 100 characters) Open
result = self._proxy.get_recipe(alias, check_updates, update, remotes, self._recorder)
- Read upRead up
- Exclude checks
Limit all lines to a maximum of 79 characters.
There are still many devices around that are limited to 80 character lines; plus, limiting windows to 80 characters makes it possible to have several windows side-by-side. The default wrapping on such devices looks ugly. Therefore, please limit all lines to a maximum of 79 characters. For flowing long blocks of text (docstrings or comments), limiting the length to 72 characters is recommended. Reports error E501.